Skip to content

Test remaining bits#18

Merged
jodal merged 6 commits intomainfrom
test-coverage
Jan 29, 2024
Merged

Test remaining bits#18
jodal merged 6 commits intomainfrom
test-coverage

Conversation

@jodal
Copy link
Copy Markdown
Member

@jodal jodal commented Jan 29, 2024

This PR takes the project's line test coverage to 100%. The test suite is
configured to fails if this is not maintained with future changes.

  • Test Cursor.get_page() with a non-existant page
  • Test various ways of opening and closing the client
  • Test 404 and 410 responses
  • Test handling of non-HTTP errors
  • Ensure all type annotations works on Python 3.8
  • Require the current full test coverage to be maintained

@codecov
Copy link
Copy Markdown

codecov bot commented Jan 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (94d681d) 95.82% compared to head (b6306f8) 100.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##             main       #18      +/-   ##
===========================================
+ Coverage   95.82%   100.00%   +4.17%     
===========================================
  Files           8         8              
  Lines         359       356       -3     
  Branches       22        21       -1     
===========================================
+ Hits          344       356      +12     
+ Misses         10         0      -10     
+ Partials        5         0       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jodal jodal merged commit 6eba1a2 into main Jan 29, 2024
@jodal jodal deleted the test-coverage branch January 29, 2024 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant