Add Apple-clang tsan to CI

[mvandeberg]

Summary by CodeRabbit

• Chores
  • Improved build configuration and testing infrastructure support for Apple Clang compiler.

[coderabbitai]

Warning

Rate limit exceeded

@mvandeberg has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 18 minutes and 30 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 002c78ec-770d-478f-ada0-be6502e8e82e

📥 Commits

Reviewing files that changed from the base of the PR and between 49d6127 and 65a6f2d.

📒 Files selected for processing (1)

• .github/generate-matrix.py

📝 Walkthrough

Walkthrough

This change modifies the GitHub build matrix generation script to extend ThreadSanitizer (TSAN) variant support to the apple-clang compiler alongside clang, while adding build-cmake flag overrides for sanitizer variants.

Changes

Cohort / File(s)	Summary
Build Matrix Configuration .github/generate-matrix.py	Added "build-cmake": False override for sanitizer and TSAN variants; expanded TSAN applicability to include apple-clang; extended conditional logic for latest compiler variants to cover apple-clang; updated TSAN docstring.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

• Add ThreadSanitizer CI builds for GCC and Clang #196: Adds ThreadSanitizer (TSAN) variant generation and integration to build matrix configuration, directly related to this PR's extension of TSAN support to apple-clang.

Poem

A rabbit hops through build matrices bright,
Threading TSAN with apple-clang's might,
No cmake builds in sanitizer's care,
Compiler support spreads far and fair! 🐰✨

🚥 Pre-merge checks | ✅ 2

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'Add Apple-clang tsan to CI' directly and accurately reflects the main change: enabling Thread Sanitizer (TSAN) testing for Apple Clang in the CI configuration.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[cppalliance-bot]

An automated preview of the documentation is available at https://198.corosio.prtest3.cppalliance.org/index.html

If more commits are pushed to the pull request, the docs will rebuild at the same URL.

2026-03-09 19:21:57 UTC

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In @.github/generate-matrix.py:
- Around line 266-268: Update the outdated comment that says "TSan is
incompatible with ASan; separate variant for Linux" to reflect the actual
behavior: this branch appends a TSan variant for gcc, clang, and apple-clang.
Edit the comment above the if-statement that checks `family in ("gcc", "clang",
"apple-clang")` (the block that calls `generate_tsan_variant(family, spec)` and
appends to `matrix`) so it no longer mentions "Linux" and instead accurately
notes that TSan variants are created for gcc/clang/apple-clang due to ASan/TSan
incompatibility.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 5df2f6c8-a6f2-41d7-bab6-07513944041d

📥 Commits

Reviewing files that changed from the base of the PR and between 68a39eb and 49d6127.

📒 Files selected for processing (1)

• .github/generate-matrix.py

[cppalliance-bot]

GCOVR code coverage report https://198.corosio.prtest3.cppalliance.org/gcovr/index.html
LCOV code coverage report https://198.corosio.prtest3.cppalliance.org/genhtml/index.html
Coverage Diff Report https://198.corosio.prtest3.cppalliance.org/diff-report/index.html

Build time: 2026-03-09 19:27:38 UTC

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.31%. Comparing base (68a39eb) to head (65a6f2d).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop     #198      +/-   ##
===========================================
+ Coverage    76.23%   76.31%   +0.07%     
===========================================
  Files           99       99              
  Lines        10570    10570              
  Branches      2407     2407              
===========================================
+ Hits          8058     8066       +8     
+ Misses        1799     1792       -7     
+ Partials       713      712       -1     

Flag	Coverage Δ
macos	66.68% <ø> (+0.18%)	⬆️
windows	70.07% <ø> (-0.02%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 3 files with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68a39eb...65a6f2d. Read the comment docs.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.