fix(plpgsql-deparser): use QuoteUtils for schema-qualified type names #276
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For schema-qualified types (e.g., schema.typename), the deparser now uses QuoteUtils from pgsql-deparser for proper identifier quoting. This ensures consistent quoting behavior between the SQL deparser and PL/pgSQL deparser. Changes: - Import QuoteUtils from pgsql-deparser - Add isSchemaQualifiedType() to detect types with dots - Add parseQualifiedTypeName() to parse dotted type names - Update deparseType() to use QuoteUtils.quoteTypeDottedName() for schema-qualified types - Preserve original format for simple types to maintain round-trip consistency - Handle array type suffixes (e.g., []) separately from the base type
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes inconsistent quoting in PL/pgSQL function bodies by using
QuoteUtilsfrompgsql-deparserfor schema-qualified type names.Problem: When deparsing PL/pgSQL functions, type names in DECLARE sections were having all quotes stripped, leading to inconsistent output:
CREATE FUNCTION "constructive_encrypted".set(...)(quoted by pgsql-deparser)v_secret constructive_encrypted.encrypted_secrets(unquoted by plpgsql-deparser)Solution: For schema-qualified types (containing a dot), the deparser now uses
QuoteUtils.quoteTypeDottedName()from pgsql-deparser for proper identifier quoting. Simple types preserve original behavior for round-trip consistency.Key changes:
QuoteUtilsfrom pgsql-deparserisSchemaQualifiedType()to detect types with dots outside quotesparseQualifiedTypeName()to parse dotted type names into parts[]) separately from base type quotingReview & Testing Checklist for Human
pnpm run generate:constructivein constructive-db and verify schema-qualified types likeconstructive_encrypted.encrypted_secretsare now consistently quoted"my""schema"."type") and array types with schema qualification (e.g.,schema.type[])Notes
Link to Devin run: https://app.devin.ai/sessions/f93a8b1ba9e54876a87e854e782a06ef
Requested by: @pyramation