Migrate all commented test cases to programmatic skip-tests.ts system#191
Merged
pyramation merged 4 commits intotransform/basefrom Jun 30, 2025
Merged
Migrate all commented test cases to programmatic skip-tests.ts system#191pyramation merged 4 commits intotransform/basefrom
pyramation merged 4 commits intotransform/basefrom
Conversation
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
- Added 162 test cases to skip-tests.ts with proper version ranges and reasons - Uncommented all test lines in kitchen-sink files to restore normal execution - Tests now use programmatic skipping via test-utils/index.ts integration - Total skip-tests.ts entries: 185 (18 existing + 162 new) - Covers version ranges: 13-14 (124 tests), 14-15 (29 tests), 15-16 (9 tests) Migration details: - Extracted all commented test cases with REMOVED reasons across 21 test files - Preserved existing skip-tests.ts structure and 18 original entries - Verified programmatic skipping works correctly with console skip messages - All 15-16 tests pass (259/259) with new programmatic skipping system - More maintainable approach than inline comments in test files Co-Authored-By: Dan Lynch <pyramation@gmail.com>
- Added missing comma after rangetypes-302.sql in test array - Resolves CI failure: 'comma expected' TypeScript error at line 309 - Maintains proper array structure for programmatic test skipping Co-Authored-By: Dan Lynch <pyramation@gmail.com>
4762dae to
2cf8f01
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrate all commented test cases to programmatic skip-tests.ts system
Summary
This PR systematically migrates all 162 commented test cases across kitchen-sink tests to the centralized
skip-tests.tsfile, replacing inline comment-based test skipping with a more maintainable programmatic approach.Key Changes:
test-utils/skip-tests.ts(bringing total to 185 entries)test-utils/index.tsintegrationMigration Coverage:
Review & Testing Checklist for Human
yarn test __tests__/kitchen-sink/13-14,yarn test __tests__/kitchen-sink/14-15,yarn test __tests__/kitchen-sink/15-16) to ensure no regressionslatest/postgres/create_am-53.sqlshould skip in 13-14 range)Diagram
%%{ init : { "theme" : "default" }}%% graph TD subgraph "Kitchen Sink Tests" A["13-14/*.test.ts"]:::minor-edit B["14-15/*.test.ts"]:::minor-edit C["15-16/*.test.ts"]:::minor-edit end subgraph "Test Infrastructure" D["test-utils/index.ts<br/>runFixtureTests()"]:::context E["test-utils/skip-tests.ts<br/>+162 entries"]:::major-edit end A --> D B --> D C --> D D --> E F["Commented Tests<br/>(// REMOVED: ...)"]:::context F -.-> E subgraph Legend L1["Major Edit"]:::major-edit L2["Minor Edit"]:::minor-edit L3["Context/No Edit"]:::context end classDef major-edit fill:#90EE90 classDef minor-edit fill:#87CEEB classDef context fill:#FFFFFFNotes
Session Info: