-
-
Notifications
You must be signed in to change notification settings - Fork 4
Bump to python-flint 0.7.0 #46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…nda-forge-pinning 2025.03.16.08.15.44
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
|
This is working on Linux now although Python 3.10 is not supported so those builds fail. I don't understand conda-forge well enough to fix the other problems. On MacOS for ARM it fails with
I guess this is a cross-compiling issue? On Windows it fails with
That means that pkgconfig could not find flint.pc although it did find gmp.pc and mpfr.pc. I don't know how that is supposed to work in conda-forge on Windows. Or maybe this is actually using flint's cmake build? If so then maybe it is cmake that needs to find flint somehow? The version of flint is still 3.0.1. I don't see where the version of flint is set but it should be 3.2.1. |
|
@conda-forge-admin rerender |
…nda-forge-pinning 2025.03.26.16.20.37
|
That seems to have fixed something. Now the Windows gets further but then fails at the point of first compiling the Cython-generated C code with: Maybe MSVC doesn't like flint.h? Or maybe meson needs to be told about the C standard like in numpy's config? https://github.com/flintlib/python-flint/blob/67c3d0d379698c95dd39b6dc3ada3fd748536d5c/meson.build#L1-L6 The MacOS ARM builds still fail with the same Bad CPU type:
|
…nda-forge-pinning 2025.03.26.16.20.37
|
Hi! This is the friendly automated conda-forge-webservice. I tried to rerender for you, but it looks like there was nothing to do. This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/14092162302. Examine the logs at this URL for more detail. |
Yes, we need to tell meson to add |
Can those be set with the It isn't clear to me where the actual build command is here but if it's a PEP 517 frontend then it should be able to pass through something like: |
recipe/meta.yaml
Outdated
| script: | ||
| - set "INCLUDE=%INCLUDE%;%LIBRARY_INC%\\flint" # [win] | ||
| - {{ PYTHON }} -m pip install . --global-option=build_ext --global-option=-DMSC_USE_DLL -vvv # [win] | ||
| - {{ PYTHON }} -m pip install . --global-option=build_ext --global-option=/experimental:c11atomics --global-option=build_ext --global-option=/std:c11 -vvv # [win] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pip help says:
--global-option Extra global options to be supplied to the setup.py call before the install or bdist_wheel command.
Is that applicable when we are not using setup.py?
I think --config-settings=setup-args= is the way to pass command line arguments to meson from pip through meson-python:
https://github.com/flintlib/python-flint/blob/117065e51d78e54050ff3a39a37912b0a2cb8e34/.github/workflows/buildwheel.yml#L194
I think it needs to be two separate strings somehow. |
Maybe it needs a newer version of visual studio? https://devblogs.microsoft.com/cppblog/c11-atomics-in-visual-studio-2022-version-17-5-preview-2/ |
|
@conda-forge-admin rerender |
…nda-forge-pinning 2025.04.16.17.20.13
|
Looks like it is all working. |
|
Thanks! |
Checklist
0(if the version changed)conda-smithy(Use the phrase@conda-forge-admin, please rerenderin a comment in this PR for automated rerendering)Closes gh-44.
Changes are mostly from gh-44 but installs meson-python instead of setuptools.