Conversation
Member
Author
|
Currently fixing the tests. |
ForNeVeR
force-pushed
the
feature/414-timeout-fix
branch
from
ea048a0 to
d302b17
Compare
ForNeVeR
force-pushed
the
feature/414-timeout-fix
branch
from
d302b17 to
9f9e145
Compare
Member
Author
|
@rexim please review! |
rexim
requested changes
Nov 29, 2016
| lazy val server = properties.getProperty("server") | ||
| lazy val xmppTimeout = { | ||
| val ms = Option(properties.getProperty("xmpp.timeout_ms")).getOrElse("5000") | ||
| Integer.parseInt(ms).milliseconds |
Member
There was a problem hiding this comment.
Why not something like?
Option(properties.getProperty("xmpp.timeout_ms"))
.map(Integer.parseInt(_))
.getOrElse(5000)
.millisecondsDoesn't invoke Integer.parseInt() if there is no xmpp.timeout_ms
Furthermore Integer.parseInt can fail with NumberFormatException. Are we gonna ignore that fact for now?
Member
Author
There was a problem hiding this comment.
Nice, will change to your proposal.
Integer.parseIntcan fail withNumberFormatException. Are we gonna ignore that fact for now?
Yes.
| socket | ||
| } | ||
|
|
||
| // These aren't used by Smack, no point to implement them |
Member
There was a problem hiding this comment.
Is this officially documented somewhere?
Member
Author
There was a problem hiding this comment.
Nope, I've just grokked through their source.
rexim
approved these changes
Nov 29, 2016
Member
Author
|
Thanks for the review. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a configurable timeout that will be used for both XMPP stuff and socket timeouts. This fixes the bug in my environment if I use 30 sec timeout.
Closes #414.