#914 - New helm chart for v1#917
Merged
deansheather merged 2 commits intocoder:masterfrom Aug 20, 2019
Merged
Conversation
paolomainardi
changed the title
paolomainardi
changed the title
paolomainardi
changed the title
paolomainardi
changed the title
deansheather
approved these changes
Aug 19, 2019
Member
deansheather
left a comment
deansheather
left a comment
There was a problem hiding this comment.
Seems pretty comprehensive. Persisting the ~/.local/share/code-server directory seems fine to me.
sr229
suggested changes
Aug 19, 2019
sr229
approved these changes
Aug 19, 2019
Contributor
sr229
left a comment
sr229
left a comment
There was a problem hiding this comment.
I can LGTM this since my suggestions were applied and OP seems to defend their config decisions adequately.
Member
|
Blocked on PGP signatures. I can merge this once you've signed all of your commits! 🔑 |
Contributor
Author
|
@deansheather signed and squashed 👍 |
Member
|
Thanks for contributing this! |
Contributor
Author
|
Thanks for merging! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs to #914
This PR adds an helm chart as another deployment option for Kubernetes.
I've made 1 opinionated decision for the persistence storage, by keeping persistent
/home/coder/projectand/home/coder/.local/share/code-serverdirectory which basically contains all the vscode configurations, such as extensions, settings etc.The helm chart includes an extensive README that should cover all the aspects to install and configure code-server.
The helm chart is now compatible with the latest stable version, but once the v2 will be out, the helm chart can be updated accordingly (it's just a matter of changing the port for now).
It still misses: