Closed
Conversation
This change is cosmetic * Remove public keyword - public by default * Remove details - this was unused throughout the entire codebase
Member
|
Ah, this actually exists so plugins can add details if they throw errors. It's true none of the code in code-server itself uses it (although maybe it should if there is a spot where some extra details could be useful). |
Contributor
Author
|
Wasn't aware, am now - TY @code-asher |
Member
|
We should probably create an explicit file with the types we want to export rather than just exporting everything so we know what's safe to change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is cosmetic (issue not linked due to being extremely minor). As part of reading the codebase for the first time, I noticed
detailsis not used anywhere.