Conversation
|
Just wondering, instead of having the matrix in the reusable workflows, why not have the calling workflows define the matrix strategy? It still feels off to me to write the matrix in pure string. It's counterintuitive to what we do normally with the matrix. For reference, look at the main repo for the test-phpunit and its underlying reusable workflow. |
|
Hmm... yes, that would probably be a much better approach - but it would introduce a BC break. The question is: do we care about backward compatibility in this case or not? From what I understand, kenjis started branch So I'm not against making changes - I just want to make sure we're on the same page about how things are supposed to work. |
|
From what I know and I asked chatgpt to confirm, files defined in this repo can also be used by other repos within the same org. So, this is for internal use only. |
|
Okay, I will try to come back with an improved version as you suggested - maybe tomorrow. |
Description
This PR introduces the ability to configure PHP versions across multiple reusable workflow templates.
All workflows now accept a
php-versionsorphp-versioninput (depending on a workflow template), which allows users to override the default PHP versions used during workflow run. The default values remain unchanged, so existing workflows will continue to work without modification.To customize the PHP versions in your project, you can now pass the input like this:
Checklist: