Test case and proposed fix for #38#39
Closed
awallgren wants to merge 4 commits intocodehaus-plexus:masterfrom
Closed
Test case and proposed fix for #38#39awallgren wants to merge 4 commits intocodehaus-plexus:masterfrom
awallgren wants to merge 4 commits intocodehaus-plexus:masterfrom
Conversation
Author
|
I'll fix that -- overeager IDE setting... |
This was referenced May 23, 2018
michael-o
reviewed
Jul 3, 2019
| // If the source file is read-only on windows, that's probably not what we want in the destination. e.g. | ||
| // jetty won't start if the web.xml or jetty-web.xml is read-only, for some reason. So after we copy, | ||
| // clear the read-only flag. | ||
| boolean setWriteable = Os.isFamily(Os.FAMILY_WINDOWS) |
Member
There was a problem hiding this comment.
I believe this is the wrong place for this. It must be in NioFiles.
hboutemy
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…xus-utils/issues/38