Added package watcher to allow gin to listen to changes in packages#64
Open
theonejb wants to merge 1 commit intocodegangsta:masterfrom
Open
Added package watcher to allow gin to listen to changes in packages#64theonejb wants to merge 1 commit intocodegangsta:masterfrom
theonejb wants to merge 1 commit intocodegangsta:masterfrom
Conversation
The package watcher looks at the package in the current working directory, and parses the source code to find out the imports. It then figures out which of those imports are outside of the GOROOT (and thus not part of the stdlib), and uses fsnotify.v1 to listen to changes to files in all those packages. This allows gin to; for example, reload the web server providing a web API to another library that is not a subpackage of the web server.
Author
|
@codegangsta First of all, gin is an amazing package that has been very useful to be over the past few days while developing a web app in Go. However, I missed having one feature from Django/Python, which is that the server will reload automatically even when an external package that the app depends on is changed. Thus; for instance, I could change the code for a third party library, and the Django server would reload automatically. I really think this can be useful to gin as well. Also, this is my first pull request ever, so I'm not sure of the right way to go about contributing to any open source project. Please let me know what the next steps in this might be, and if you'll consider merging this in. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The package watcher looks at the package in the current working directory,
and parses the source code to find out the imports. It then figures out
which of those imports are outside of the GOROOT (and thus not part of the stdlib),
and uses fsnotify.v1 to listen to changes to files in all those packages.
This allows gin to; for example, reload the web server providing a web API to another
library that is not a subpackage of the web server.