Fix the way to use puppeteer console message#910
Merged
DavertMik merged 1 commit intocodeceptjs:masterfrom Feb 5, 2018
Merged
Conversation
Contributor
|
Thanks for fixing, just as I thought there is something wrong there :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, I saw issue #889 and #891 try to fix it.
But the solution is incorrect.
Base on the puppeteer API and code.
This object only have get method. And return value of
args()is Non-nullable.So I fix the code to align the API.
I have tested on my test case (encounter issue #889 before), and it works fine now.