Skip to content

fix: masked value issue in data table #3885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kobenguyent merged 2 commits into from
Oct 6, 2023
Merged

fix: masked value issue in data table #3885

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c80df20
fix: masked value issue in data table
kobenguyent Sep 22, 2023
80b5e4d
Merge branch '3.x' into fix-masked-value-issue-in-data-table
kobenguyent Sep 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 14 additions & 6 deletions lib/data/context.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ module.exports = function (context) {
.inject({ current: dataRow.data }));
}
});
maskSecretInTitle(scenarios);
return new DataScenarioConfig(scenarios);
},
only: {
Expand All @@ -42,6 +43,7 @@ module.exports = function (context) {
.inject({ current: dataRow.data }));
}
});
maskSecretInTitle(scenarios);
return new DataScenarioConfig(scenarios);
},
},
Expand Down Expand Up @@ -71,12 +73,6 @@ function replaceTitle(title, dataRow) {
// it should be printed
if (Object.prototype.toString.call(dataRow.data) === (Object()).toString()
&& dataRow.data.toString() !== (Object()).toString()) {
Object.entries(dataRow.data).forEach(entry => {
const [key, value] = entry;
if (value instanceof Secret) {
dataRow.data[key] = value.getMasked();
}
});
return `${title} | ${dataRow.data}`;
}

Expand Down Expand Up @@ -119,3 +115,15 @@ function detectDataType(dataTable) {

throw new Error('Invalid data type. Data accepts either: DataTable || generator || Array || function');
}

function maskSecretInTitle(scenarios) {
scenarios.forEach(scenario => {
const res = [];

scenario.test.title.split(',').forEach(item => {
res.push(item.replace(/{"_secret":"(.*)"}/, '"*****"'));
});

scenario.test.title = res.join(',');
});
}