Skip to content

fix(datatable): mask secret text #3432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
DavertMik merged 1 commit into from
Oct 5, 2022
Merged

fix(datatable): mask secret text #3432

DavertMik merged 1 commit into from
Oct 5, 2022

Conversation

@kobenguyent
Copy link
Collaborator

@kobenguyent kobenguyent commented Sep 29, 2022

Motivation/Description of the PR

Type of change

  • 🐛 Bug fix

Checklist:

  • Tests have been added
  • Local tests are passed (Run npm test)

@Arhell Arhell requested a review from DavertMik October 2, 2022 06:34
@DavertMik DavertMik merged commit fd46c09 into 3.x Oct 5, 2022
@DavertMik DavertMik deleted the fix-data-table-with-secret-instance branch October 5, 2022 10:29
@DavertMik
Copy link
Contributor

DavertMik commented Oct 5, 2022

Thanks!

nlespiaucq pushed a commit to nlespiaucq/CodeceptJS that referenced this pull request Oct 27, 2022
@kobenguyent @nlespiaucq
fix(datatable): mask secret text (codeceptjs#3432)
af7226d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DavertMik DavertMik DavertMik approved these changes

@Arhell Arhell Arhell approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Passwords stored with secret() are written to output when using data-driven tests

4 participants

@kobenguyent @DavertMik @Arhell