Fix error suppression for failed gherkin step#2745
Merged
Georgegriff merged 2 commits intocodeceptjs:3.xfrom Feb 1, 2021
Merged
Fix error suppression for failed gherkin step#2745Georgegriff merged 2 commits intocodeceptjs:3.xfrom
Georgegriff merged 2 commits intocodeceptjs:3.xfrom
Conversation
Contributor
|
I'm looking for this change, I've found a silent error on my tests. |
Contributor
|
@ktryniszewski-mdsol do you have any contact that would help prioritize this? |
Contributor
Author
Hopefully @DavertMik can take a look soon and merge. In the meantime you can probably just downgrade to 3.0.2 unless there was something you specifically needed in the higher version |
Georgegriff
approved these changes
Jan 29, 2021
Collaborator
Georgegriff
left a comment
There was a problem hiding this comment.
Our unit tests were broken here, swallowing the error, so it missed this! I've fixed the unit tests in this pr too :) thanks for the fix!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation/Description of the PR
Applicable helpers:
Applicable plugins:
Type of change
Checklist:
npm run docs)npm run lint)npm test)