Add skipped event listener for allure#2369
Merged
DavertMik merged 2 commits intocodeceptjs:masterfrom May 3, 2020
Merged
Conversation
DavertMik
approved these changes
Apr 29, 2020
DavertMik
requested changes
Apr 30, 2020
DavertMik
approved these changes
May 3, 2020
Collaborator
|
Im seeing flakey unit tests due to this change in allure_test.js It appears that two test reports are now generated on failure: @DavertMik @koushikmohan1996 It could be that this PR fixes the same issue, perhaps in a better way. If so we should remove the existing code that catches errors. The downside to this new fix is it appears the original error is lost? which means debugging why a test failed will be very hard |
Collaborator
|
Update: Looks like the two changes work nicely together, however not with workers :/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation/Description of the PR
Applicable plugins:
Type of change
Checklist:
npm run docs)npm run lint)npm test)