Navigation timeout of Playwright is disabled by default

[henrypoon]

What are you trying to achieve?

Keep the timeout condition that Playwirght has - 30s by default and it's set to 0 i.e. disabled in DEBUG mode if no custom value is provided.

What do you get instead?

Navigation timeout is disabled by default as setDefaultNavigationTimeout is set by getPageTimeout which has a default value of 0.

Details

I've been trying to debug a potential page crash issue in CI, however, the test just hangs there forever until it got killed. I'd expect to still have the timeout enabled by default or keep it as Playwright does.

defaults in Playwright.js

    const defaults = {
      // options to emulate context
      emulate: {},

      browser: 'chromium',
      waitForAction: 100,
      waitForTimeout: 1000,
      pressKeyDelay: 10,
      fullPageScreenshots: false,
      disableScreenshots: false,
      uniqueScreenshotNames: false,
      manualStart: false,
      getPageTimeout: 0,
      waitForNavigation: 'load',
      restart: false,
      keepCookies: false,
      keepBrowserState: false,
      show: false,
      defaultPopupAction: 'accept',
      ignoreHTTPSErrors: false, // Adding it here o that context can be set up to ignore the SSL errors
    };

• CodeceptJS version: 3.0.7
• NodeJS Version: 12.20.1
• Operating System: MacOS Big Sur
• Playwright

[Xotabu4]

@henrypoon Got stuck recently with same issue. For sure by default getPageTimeout should not be set to 0, since this causes endless waiting for some broken page that we have in project. I assume 30-60 seconds should be fine as default value

@DavertMik want me to send PR for this?

codeceptjs/lib/helper/Playwright.js:252

[DavertMik]

@Xotabu4 yes,please 😁