fix: validate locale cookie before setting I18n locale#2497
Merged
mroderick merged 1 commit intocodebar:masterfrom Feb 21, 2026
Merged
fix: validate locale cookie before setting I18n locale#2497mroderick merged 1 commit intocodebar:masterfrom
mroderick merged 1 commit intocodebar:masterfrom
Conversation
Fixes I18n::InvalidLocale error when cookie contains invalid/empty locale. Root cause: ApplicationController#set_locale was using the cookie value directly without validation, causing failures when users had an empty or invalid locale stored from previous sessions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I18n::InvalidLocaleerror when locale cookie contains invalid/empty valuelocale_valuehelper to validate cookie before settingI18n.localeAnalysis
The error occurred in
ApplicationController#set_locale:Root cause: The cookie value was used directly without validation. When a user had previously set an empty or invalid locale (e.g.,
""), the line would attemptI18n.locale = ""which fails because""is not a valid locale symbol.Fix: Added
locale_valuemethod that validates the cookie is present AND is in the available locales before using it, otherwise falls back to default locale.