Fix empty coaches list in workshop feedback + parallel test improvements #2456
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
@mroderick The other PR is merged, so that 1 commit in this PR can be rebased on top of latest changes. |
Resolves issue where no coaches appeared in the feedback dropdown when students tried to submit workshop feedback. Root cause: The feedback controller was filtering for coaches where attended=true, but attendance is only marked after organizers manually verify it. When feedback emails are sent (the day after workshop), coaches have attending=true but attended=nil. Changes: - Updated set_coaches to use accepted_or_attended scope instead of attended - Added ORDER BY with NULLS LAST to prioritize verified coaches first - Added test for coaches who RSVPd but haven't been verified yet - Added test for verified coaches appearing before unverified coaches This allows students to submit feedback immediately after workshops, even before organizers verify attendance, while still prioritizing verified coaches when that data is available. Fixes codebar#2367
mroderick
force-pushed
the
issue-2367-workshop-feedback
branch
from
9d750b8 to
544c848
Compare
Collaborator
|
@mroderick 🎉 Celebrate! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The branch from this PR has been branched from #2455, please review and merge that one first and then rebase this one.
Summary
This PR includes two major improvements:
1. Fix Issue #2367 - Empty coaches list in workshop feedback form
Problem: When students tried to submit workshop feedback, the coaches dropdown was empty and they couldn't complete the form.
Root Cause: The feedback controller filtered for coaches where
attended=true, but:attended=truewhen organizers manually verify attendanceattending=truebutattended=nilSolution:
accepted_or_attendedscope (includes coaches who either RSVP'd OR had attendance verified)ORDER BY attended DESC NULLS LASTto prioritize verified coaches firstTests Added:
Fixes #2367
Test Results
All tests passing:
Screenshots
Before (Issue #2367)
No coaches in dropdown - user cannot submit feedback
After (Issue #2367)
Coaches appear in dropdown, verified coaches listed first