Organisers can create new Sponsors without adding in number of coache…

[joaoguiIherme]

…s/students but it will 404

This PR fixs issue #1794.
Also fixes some bugs in tests.

[KimberleyCook]

Hey @joaoguiIherme thank you so much for this PR. One of the codebar team will try to review it as soon as possible

[KimberleyCook]

@matyikriszta when you get some time could you review this PR please?

[matyikriszta]

@joaoguiIherme do we need the closing parenthesis at the end of this line? I think the next line (11) closes the parenthesis opened on line 8.

[matyikriszta]

Suggested change

	validates :seats, presence: true, numericality: { greater_tha_or_equal_to: 0, only_integer: true }
	validates :seats, presence: true, numericality: { greater_than_or_equal_to: 0, only_integer: true }

[matyikriszta]

Sorry for the delay on reviewing this @joaoguiIherme, I left two small comments, but overall it looks good. Thanks for fixing up the tests too.

[matyikriszta]

@joaoguiIherme will you be able to make the updates I requested or I'd be happy to make them myself, I'd be keen to get this PR merged in.

[github-actions]

This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[davidmillen50]

@matyikriszta I tried checking out this branch to add the changes and I'm not able to I assume because it was created years ago. I suggest someone else tries checking out the branch

[mikej]

@davidmillen50 I've been able to check out the branch (and can show you how if you'd like).

To fix conflicts and make @matyikriszta's suggested changes I think that I, or someone else, will need to create a new PR from a branch in their own fork?

[davidmillen50]

Thanks @mikej if you can send me the git commands I'll have a go. Regarding the edits: I would hope we can make changes to this branch directly without creating a new PR

[till]

You can checkout a from a "fork" like so:

1. Add a new remote of the git repo
2. Update the remote
3. Checkout the branch from the remote

git remote add codevolving https://github.com/Codevolving/planner
git fetch codevolving
git checkout -t codevolving/fix-create-new-sponsor-issue

When you are done, you can push the branch to your own fork and create a new PR.

[matyikriszta]

@davidmillen50 I don't mind if we create a new fixed PR. It would be good to merge this change in.

[davidmillen50]

@matyikriszta I no longer have time to pick this up unfortunately