Add configurable identifier_field analagous to existing timestamp_field.#76
Merged
Add configurable identifier_field analagous to existing timestamp_field.#76
identifier_field analagous to existing timestamp_field.#76Conversation
To be used for a feature I actually need in the ActiveRecordWrapper, and will implement there next. Sorry, haven't figured out how to test this at present. The customizable timestamp_field does not seem to be tested either.
With limited test.
This was referenced Aug 26, 2019
This was referenced Jan 14, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You may not always want it to be assumed to be
id. Now it's customizable, liketimestamp_fieldis.And the ActiveRecordWrapper is enhanced to use it properly, so you can use a field other than your primary key for what gets turned into the oai-pmh identifier.
There is a limited tests of ActiveRecordWrapper using this new func with GetRecord. More tests would be good, but it's challenging with the current test architecture. Note that custom
timestamp_fieldalso has limited (possibly no?) testing, either in general or with ActiveRecordWrapper.This change should be entirely backwards compatible.
@jrochkind did need this for his use case.
Ref #61