chore(utils): move benchmarks to typescript, adjust types#253
Merged
MishaSeredenkoPushBased merged 2 commits intomainfrom Nov 14, 2023
Merged
chore(utils): move benchmarks to typescript, adjust types#253MishaSeredenkoPushBased merged 2 commits intomainfrom
MishaSeredenkoPushBased merged 2 commits intomainfrom
Conversation
MishaSeredenkoPushBased
added
🧹 maintenance
💡 good first issue
MishaSeredenkoPushBased
requested review from
BioPhoton,
IKatsuba,
Tlacenka,
matejchalk and
vmasek
BioPhoton
reviewed
Nov 14, 2023
Collaborator
BioPhoton
left a comment
BioPhoton
left a comment
There was a problem hiding this comment.
Nice that we caught the broken implementations with TS :D
matejchalk
reviewed
Nov 14, 2023
matejchalk
approved these changes
Nov 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All benchmarks are now .ts, added types where necessary.
Fixed some places in the benchmarked functions, where they returned not proper values - it was the reason of the high scores of optimized1 and optimized2 benchmarks 🙂
Used tsx for runtime, modified perf command, changed tsconfig.lib at utils.
Closes #154