Merged
Conversation
5c1645b to
06e0a9e
Compare
06e0a9e to
e65c87d
Compare
| |> assign(:changeset, changeset) | ||
| |> Canary.Plugs.authorize_resource(model: changeset) | ||
| end | ||
| defp authorized?(conn), do: conn |> Map.get(:assigns) |> Map.get(:authorized) |
Contributor
There was a problem hiding this comment.
Should these two methods be added to controller helpers since they are used in multiple controllers?
Contributor
Author
There was a problem hiding this comment.
I'm not really sure. Maybe a brand new authorization_helpers would make more sense.
Contributor
|
Looks good! Just had one comment. Will look over again though later to make sure I didnt miss anything |
… on database level
e65c87d to
fd90858
Compare
Contributor
Author
|
@npendery I've moved the two functions into |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was done
CommentController#indexwas lacking the "filter by ID functionality", so I added it and specs to support the feature.PostController.indexwas missing filtering by status, so I added that as wellOrganizationMembershipControler#indexwas filtering bymember_idinstead ofid. Fixed that bug.CategoryController#indexwas missing some preloadsUserwas missing the default "signed_up" state upon creation, so the onboarding process would never trigger.UserCategory,UserRoleandUserSkill