Closed
Conversation
SimonFrings
reviewed
Dec 16, 2022
Contributor
SimonFrings
left a comment
SimonFrings
left a comment
There was a problem hiding this comment.
@bartvanhoutte Thanks for opening this PR, looks great so far 👍
I added some remarks below, can you also squash your commits into one, I don't think we need that many.
| public $pending; | ||
|
|
||
| public $args; | ||
| } No newline at end of file |
Comment on lines
3
to
4
| namespace Clue\React\Mq; | ||
| final class State |
Contributor
There was a problem hiding this comment.
Suggested change
| namespace Clue\React\Mq; | |
| final class State | |
| namespace Clue\React\Mq; | |
| /** @internal */ | |
| final class State |
Just added some white space and I think we should mark this class as internal
Contributor
|
And should we give the |
…e/reactphp-mq into feature/php8.2-deprecations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR as discussed in #35.