Improve error reporting for invalid responses by using ResponseException#51
Merged
Improve error reporting for invalid responses by using ResponseException#51
ResponseException#51Conversation
There was a problem hiding this comment.
Pull request overview
This PR improves permanent error reporting for EventSource when the initial HTTP response is invalid (non-200 status or invalid/missing Content-Type), switching emitted errors to React\Http\Message\ResponseException so consumers can access the underlying response.
Changes:
- Emit
ResponseExceptionwith descriptive, safely-quoted error messages for invalid status codes and invalidContent-Type. - Add a small internal
quote()helper to truncate/escape response details in error messages. - Update tests to cover multiple invalid status/content-type cases via data providers and assert
ResponseExceptionbehavior; update README accordingly.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/EventSource.php |
Emits ResponseException for permanent failures and adds quoting helper for safe, bounded error details. |
tests/EventSourceTest.php |
Expands assertions and cases (status + content-type) to validate new exception type/message/response access. |
README.md |
Fixes example variable name and documents ResponseException behavior for permanent failures. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changeset improves error reporting when the EventSource connection receives an invalid response (non-200 status code or invalid
Content-Typeheader). The first commit improves error messages to be more descriptive, the second commit switches toResponseExceptionwhich provides access to the response object.Builds on top of #14, #2, #32 and others, follows similar approach as clue/framework-x#284