Skip to content

Comments

fix: Better Go build flags for plugins packaging#2415

Merged
kodiakhq[bot] merged 1 commit intomainfrom
fix/use_trimpath_plugins_builds
Feb 23, 2026
Merged

fix: Better Go build flags for plugins packaging#2415
kodiakhq[bot] merged 1 commit intomainfrom
fix/use_trimpath_plugins_builds

Conversation

@erezrokah
Copy link
Member

Summary

trimpath and buildvcs are better for cache re-usability and reproducible builds (we already include plugins versions in resources/plugin.Version so we don't need the VCS data).
Also mod=readonly ensures go build doesn't modify go.mod or go.sum


Use the following steps to ensure your PR is ready to be reviewed

  • Read the contribution guidelines 🧑‍🎓
  • Run go fmt to format your code 🖊
  • Lint your changes via golangci-lint run 🚨 (install golangci-lint here)
  • Update or add tests 🧪
  • Ensure the status checks below are successful ✅

Copilot AI review requested due to automatic review settings February 23, 2026 17:39
@erezrokah erezrokah requested a review from a team as a code owner February 23, 2026 17:39
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request improves the Go build configuration for plugin packaging by adding three standard build flags that enhance reproducibility and cache reusability.

Changes:

  • Added -trimpath, -buildvcs=false, and -mod=readonly flags to the Go build command used for plugin packaging

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@kodiakhq kodiakhq bot merged commit 934226b into main Feb 23, 2026
13 checks passed
@kodiakhq kodiakhq bot deleted the fix/use_trimpath_plugins_builds branch February 23, 2026 17:51
kodiakhq bot pushed a commit that referenced this pull request Feb 23, 2026
🤖 I have created a release *beep* *boop*
---


## [4.94.3](v4.94.2...v4.94.3) (2026-02-23)


### Bug Fixes

* Better Go build flags for plugins packaging ([#2415](#2415)) ([934226b](934226b))
* **deps:** Update module github.com/cloudquery/codegen to v0.3.37 ([#2410](#2410)) ([c812b39](c812b39))
* **deps:** Update module github.com/cloudquery/plugin-pb-go to v1.27.7 ([#2414](#2414)) ([51f4d60](51f4d60))
* **deps:** Update module google.golang.org/grpc to v1.79.1 ([#2412](#2412)) ([f617806](f617806))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants