fix: Don't lose IP data in AppendValueFromString#2236
Merged
kodiakhq[bot] merged 2 commits intomainfrom Jul 23, 2025
Merged
Conversation
erezrokah
changed the title
AppendValueFromString
5 tasks
murarustefaan
approved these changes
Jul 23, 2025
kodiakhq bot
pushed a commit
that referenced
this pull request
Jul 23, 2025
🤖 I have created a release *beep* *boop* --- ## [4.87.4](v4.87.3...v4.87.4) (2025-07-23) ### Bug Fixes * **deps:** Update module github.com/apache/arrow-go/v18 to v18.4.0 ([#2234](#2234)) ([3955c1d](3955c1d)) * Don't lose IP data in `AppendValueFromString` ([#2236](#2236)) ([6f1db88](6f1db88)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
kodiakhq bot
pushed a commit
to cloudquery/filetypes
that referenced
this pull request
Jul 23, 2025
….4 (#665) #### Summary Goes with cloudquery/plugin-sdk#2236 We should probably change our testing method to something that makes it easier to see the difference, but you can see the old snapshot has `1.148.0.0/15` and the new one has `1.148.253.194/15` (search `"inet"` to see other examples). ---
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reverts #2205 as we were actually losing the IP data in some cases (in
AppendValueFromString).This PR ensures we don't lose the IP data
Use the following steps to ensure your PR is ready to be reviewed
go fmtto format your code 🖊golangci-lint run🚨 (install golangci-lint here)