Skip to content

feat: Log resource when exception occurs to aid debugging #172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kodiakhq merged 2 commits into from
May 17, 2024
Merged

feat: Log resource when exception occurs to aid debugging #172

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
057cae1
Log resource when exception occurs to aid debugging
hermanschaaf May 17, 2024
36b1988
Add details about resource in separate debug message
hermanschaaf May 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions cloudquery/sdk/scheduler/scheduler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,12 @@ def resolve_table(
depth=depth,
exc_info=e,
)
self._logger.debug(
"details about resource that failed to resolve",
client_id=client.id(),
table=resolver.table.name,
resource=item,
)
Comment on lines +119 to +124
Copy link

@bbernays bbernays May 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a better approach that balances user experience with security

continue
res.put(SyncInsertMessage(resource.to_arrow_record()))
for child_resolvers in resolver.child_resolvers:
Expand Down