Skip to content

fix: SyncMigrateTableMessage should have the pa.Schema argument named as "table" #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
disq merged 2 commits into from
Aug 1, 2023
Merged

fix: SyncMigrateTableMessage should have the pa.Schema argument named as "table" #13

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2a2fe07
fix: SyncMigrateTableMessage should have the `pa.Schema` argument nam…
disq Aug 1, 2023
57bc008
fmt (so close)
disq Aug 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cloudquery/sdk/internal/servers/plugin_v3/plugin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ def Sync(self, request, context):
insert=plugin_pb2.Sync.MessageInsert(record=buf)
)
elif isinstance(msg, SyncMigrateTableMessage):
buf = arrow.schema_to_bytes(msg.schema)
buf = arrow.schema_to_bytes(msg.table)
yield plugin_pb2.Sync.Response(
migrate_table=plugin_pb2.Sync.MessageMigrateTable(table=buf)
)
Expand Down
8 changes: 4 additions & 4 deletions cloudquery/sdk/message/sync.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,11 @@ class SyncMessage:
pass


class SyncInsertMessage:
class SyncInsertMessage(SyncMessage):
def __init__(self, record: pa.RecordBatch):
self.record = record


class SyncMigrateTableMessage:
def __init__(self, schema: pa.Schema):
self.schema = schema
class SyncMigrateTableMessage(SyncMessage):
def __init__(self, table: pa.Schema):
self.table = table
2 changes: 1 addition & 1 deletion cloudquery/sdk/scheduler/scheduler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,7 @@ def sync(
) -> Generator[SyncMessage, None, None]:
res = queue.Queue()
for resolver in resolvers:
yield SyncMigrateTableMessage(schema=resolver.table.to_arrow_schema())
yield SyncMigrateTableMessage(table=resolver.table.to_arrow_schema())
thread = futures.ThreadPoolExecutor()
thread.submit(self._sync, client, resolvers, res, deterministic_cq_id)
total_table_resolvers = 0
Expand Down