Skip to content

[WIP] Support Python 3.7 in Cloudpickle#181

Closed
HyukjinKwon wants to merge 1 commit intocloudpipe:masterfrom
HyukjinKwon:python-3-7
Closed

[WIP] Support Python 3.7 in Cloudpickle#181
HyukjinKwon wants to merge 1 commit intocloudpipe:masterfrom
HyukjinKwon:python-3-7

Conversation

@HyukjinKwon
Copy link
Member

This PR targets to support Python 3.7 in Cloudpickle.

- "3.4"
- "3.5"
- "3.6"
- "3.7"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently blocked by https://github.com/travis-ci/travis-ci/issues/9552.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can start installing Miniconda and create different versioned Python environments for each matrix element?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks there are workarounds for it, for instance, travis-ci/travis-ci#9815 (comment) . I don't think this is super urgent and we could just wait for its support though.

@HyukjinKwon HyukjinKwon reopened this Jul 23, 2018
@codecov-io
Copy link

codecov-io commented Jul 23, 2018

Codecov Report

Merging #181 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #181   +/-   ##
=======================================
  Coverage   83.85%   83.85%           
=======================================
  Files           1        1           
  Lines         539      539           
  Branches       95       95           
=======================================
  Hits          452      452           
  Misses         63       63           
  Partials       24       24

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4818995...8d7cd61. Read the comment docs.

@HyukjinKwon HyukjinKwon closed this Aug 3, 2018
@HyukjinKwon HyukjinKwon reopened this Aug 3, 2018
@tomMoral
Copy link
Contributor

I am currently working on python3.7 support with #189.
I think you can close this one.

@HyukjinKwon
Copy link
Member Author

Yea, thx.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants