fix(security-scans): use step outcome instead of conclusion for snyk#392
Merged
fix(security-scans): use step outcome instead of conclusion for snyk#392
Conversation
The Snyk step uses `continue-on-error: true`, which overrides `conclusion` to `success` even when Snyk fails. The downstream steps checking `steps.snyk.conclusion` would always run, causing the pipeline to break when Snyk didn't produce a sarif file. Use `outcome` instead, which reflects the actual result of the step before `continue-on-error` is applied. Signed-off-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com>
mnencia
requested review from
NiccoloFei,
fcanovai,
gbartolini,
jbattiato,
litaocdl and
sxd
as code owners
dosubot
bot
added
size:XS
NiccoloFei
approved these changes
Feb 16, 2026
sxd
approved these changes
Feb 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Snyk step uses
continue-on-error: true, which overridesconclusiontosuccesseven when Snyk fails. The downstream steps checkingsteps.snyk.conclusionwould always run, causing the pipeline to break when Snyk didn't produce a sarif file.Use
outcomeinstead, which reflects the actual result of the step beforecontinue-on-erroris applied.