Fix actual_lrps_by_processes function#4870
Merged
jochenehret merged 1 commit intomainfrom Feb 24, 2026
Merged
Conversation
* check for empty processes and don't call the Diego backend (would result in process_guids must not be empty error)
sethboyles
approved these changes
Feb 23, 2026
philippthun
approved these changes
Feb 24, 2026
ari-wg-gitbot
added a commit
to cloudfoundry/capi-release
that referenced
this pull request
Feb 24, 2026
Changes in cloud_controller_ng:
- Fix actual_lrps_by_processes function
PR: cloudfoundry/cloud_controller_ng#4870
Author: Jochen Ehret <jochen.ehret@sap.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A short explanation of the proposed change:
Fix
actual_lrps_by_processesfunction. If an empty list of processes is passed, don't call the Diego API.An explanation of the use cases your change solves
Avoids cloud controller "UnknownError" e.g. when
/v3/processes?space_guids=:guid&embed=process_instancesis called on an empty space.Links to any other associated PRs
Implement GET /v3/processes/:guid/process_instances and embed=process_instances #4796
I have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
mainbranchI have run all the unit tests using
bundle exec rakeI have run CF Acceptance Tests