Skip to content

Replace custom DNS lookback address #3498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
a-b merged 1 commit into from
Apr 29, 2025
Merged

Replace custom DNS lookback address #3498

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions api/cloudcontroller/cloud_controller_connection_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -292,9 +292,9 @@ var _ = Describe("Cloud Controller Connection", func() {
connection = NewConnection(Config{})
})

// loopback.cli.fun is a custom DNS record setup to point to 127.0.0.1
// 127.0.0.1.nip.io is a custom DNS record setup to point to 127.0.0.1
It("returns a SSLValidationHostnameError", func() {
altHostURL := strings.Replace(server.URL(), "127.0.0.1", "loopback.cli.fun", -1)
altHostURL := strings.Replace(server.URL(), "127.0.0.1", "127.0.0.1.nip.io", -1)
req, err := http.NewRequest(http.MethodGet, altHostURL, nil)
Expect(err).ToNot(HaveOccurred())
request := &Request{Request: req}
Expand All @@ -304,10 +304,10 @@ var _ = Describe("Cloud Controller Connection", func() {
Expect(err).To(
SatisfyAny(
MatchError(ccerror.SSLValidationHostnameError{
Message: "x509: certificate is valid for example.com, *.example.com, not loopback.cli.fun",
Message: "x509: certificate is valid for example.com, *.example.com, not 127.0.0.1.nip.io",
}),
MatchError(ccerror.SSLValidationHostnameError{
Message: "x509: certificate is valid for example.com, not loopback.cli.fun",
Message: "x509: certificate is valid for example.com, not 127.0.0.1.nip.io",
})))
})
})
Expand Down
8 changes: 4 additions & 4 deletions api/plugin/plugin_connection_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,9 +192,9 @@ var _ = Describe("Plugin Connection", func() {
connection = NewConnection(false, 0)
})

// loopback.cli.fun is a custom DNS record setup to point to 127.0.0.1
// 127.0.0.1.nip.io is a DNS record setup to point to 127.0.0.1
It("returns a SSLValidationHostnameError", func() {
altHostURL := strings.Replace(server.URL(), "127.0.0.1", "loopback.cli.fun", -1)
altHostURL := strings.Replace(server.URL(), "127.0.0.1", "127.0.0.1.nip.io", -1)
request, err := http.NewRequest(http.MethodGet, altHostURL, nil)
Expect(err).ToNot(HaveOccurred())

Expand All @@ -203,10 +203,10 @@ var _ = Describe("Plugin Connection", func() {
Expect(err).To(
SatisfyAny(
MatchError(pluginerror.SSLValidationHostnameError{
Message: "x509: certificate is valid for example.com, *.example.com, not loopback.cli.fun",
Message: "x509: certificate is valid for example.com, *.example.com, not 127.0.0.1.nip.io",
}),
MatchError(pluginerror.SSLValidationHostnameError{
Message: "x509: certificate is valid for example.com, not loopback.cli.fun",
Message: "x509: certificate is valid for example.com, not 127.0.0.1.nip.io",
})))
})
})
Expand Down
Loading