Add CurrentDropletGUID attribute to application resource [main]#3354
Merged
joaopapereira merged 3 commits intocloudfoundry:mainfrom Feb 3, 2025
Merged
Conversation
3 tasks
joaopapereira
suggested changes
Jan 21, 2025
Contributor
joaopapereira
left a comment
joaopapereira
left a comment
There was a problem hiding this comment.
Thanks for the PR.
I added some suggestions on naming, but I would like to see some tests to make sure that we are covering this change. They can be in unit tests in api/cloudcontroller/ccv3/relationship_test.go
Contributor
|
I updated the current PR with the latest changes in |
gmllt
force-pushed
the
add-current-droplet-relationships-for-apps-main
branch
from
d63f6b2 to
e739a62
Compare
Member
Author
|
@joaopapereira thank you for your review. I made some changes to address your feedback. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Where this PR should be backported?
Description of the Change
The V3 API now allows you to access to the relationships existing beween an app and its current droplet.
This PR make this relationship visible trough a new
CurrentDropletGUIDattribute in the resourceapplication.The community
cf_exportercurrently use the/v2/spaces/:guid/summaryendpoint to gain access to buildpack associated to an application. Have this relationship visible would help get rid of calls on this endpoint and retrieve informations from bbs about DesiredLRPs and RunningLRPS.This feature will not cause breaking change.