Conversation
1683294 to
8057cbf
Compare
37b425f to
2203c4e
Compare
2203c4e to
ed61add
Compare
Contributor
|
@Samze any update on this PR? |
Contributor
Author
This dropped off my radar over the holidays, hope to pick this back up and finish it off in the next week or two. |
a-b
approved these changes
Mar 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3309
Description of the Change
The CLI now sets the B3_TRACE headers as per https://docs.cloudfoundry.org/adminguide/distributed-tracing.html#unique-trace-id.
Notes:
X-B3-Traceidheader for all API requests initiated by that CF command. (e.g. use the same header for all api calls for the commandcf apps).X-B3-Spanidper API request.CF_B3_TRACE_IDthat allows theX-B3-Traceidto be overridden.X-Vcap-Request-Idto the same header as theX-B3-Traceid(in uuid v4 format) and will work withW3Cheaders if `router.tracing.enable_w3c is set.CF_TRACEor-vWhy Is This PR Valuable?
See #3309
Examples
With auto-generated headers:
With environment variable override: