Fix polling of async v3 jobs and make getLastOperation method public#1171
Merged
mheath merged 2 commits intocloudfoundry:mainfrom Jan 25, 2023
Merged
Fix polling of async v3 jobs and make getLastOperation method public#1171mheath merged 2 commits intocloudfoundry:mainfrom
mheath merged 2 commits intocloudfoundry:mainfrom
Conversation
Later in v3 job object was added state POLLING related with async operations with service brokers. The check of job state doesn't handle properly POLLING status and doesn't wait at all.
boyan-velinov
approved these changes
Nov 11, 2022
dmikusa
approved these changes
Nov 11, 2022
Contributor
|
Hello @dmikusa, |
Contributor
|
The CI for this runs on VMware's infrastructure. I no longer work at VMware, so I don't have access anymore to run the integration tests & check if there are issues. @pivotal-david-osullivan needs to do that for the time being. Last I heard, the CFF is working on setting up some environments so it might be possible over time to move this infrastructure out of VMware to the CFF, where it would be public. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fix related with
waitForCompletionmethod is related to state POLLING .Second change is related with ability to use "lastOperation" field from ServiceBinding