Locally use the options to read the port#36
Closed
smg-bg wants to merge 2 commits intocloudfoundry-community:masterfrom
Closed
Locally use the options to read the port#36smg-bg wants to merge 2 commits intocloudfoundry-community:masterfrom
smg-bg wants to merge 2 commits intocloudfoundry-community:masterfrom
Conversation
Member
|
Sorry for the delay in responding, somehow I missed seeing this. This fix seems reasonable to me. I'll try it out and merge in a bit ... |
Member
|
I've merged this into master, and it's now available in cfenv 1.2.0 on npm. Thanks so much for your contribution, and again, sorry for the delay! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were trying to use the library with providing the vcapFile, but whenever we change the application port it's not reflected in the returned port.
It's a really simple fix, but we would want to hear your opinion and if possible to merge it back.