Skip to content

Cherrypick CCV3 internal router simplication - ad368258f69784e799d08a…#8

Open
sleungcy-sap wants to merge 1 commit intocloudfoundry-community:v0.0.11-complete-apifrom
sleungcy-sap:router-simplification
Open

Cherrypick CCV3 internal router simplication - ad368258f69784e799d08a…#8
sleungcy-sap wants to merge 1 commit intocloudfoundry-community:v0.0.11-complete-apifrom
sleungcy-sap:router-simplification

Conversation

@sleungcy-sap
Copy link

@sleungcy-sap sleungcy-sap commented May 16, 2024

Cherry picked ad36825

Author: Merric De Launey mdelauney@pivotal.io
Date: Thu Jul 9 21:04:52 2020 +0000
Simplify CCV3 internal router

- Now, we don't need to hit `/v3` before every command to populate the
router. Instead, we have just written the resource names directly into
the routes file.
- Refactor the routes file to be a map keyed by route name, instead of
an array of routes that gets later converted into a map on the fly.
- The `GetInfo()` method now does not return `ccv3.ResourceLinks`,
because we don't hit `/v3`.

Slack discussion where we asked if anyone knew why it was so complicated
(and nobody really knew):
https://cloudfoundry.slack.com/archives/C032824SM/p1594316115396400

Co-authored-by: Merric De Launey <mdelauney@pivotal.io>
Co-authored-by: Reid Mitchell <rmitchell@pivotal.io>

Thank you for contributing to the CF CLI! Please read the following:

Author: Merric De Launey <mdelauney@pivotal.io>
Date:   Thu Jul 9 21:04:52 2020 +0000
    Simplify CCV3 internal router

    - Now, we don't need to hit `/v3` before every command to populate the
    router. Instead, we have just written the resource names directly into
    the routes file.
    - Refactor the routes file to be a map keyed by route name, instead of
    an array of routes that gets later converted into a map on the fly.
    - The `GetInfo()` method now does not return `ccv3.ResourceLinks`,
    because we don't hit `/v3`.

    Slack discussion where we asked if anyone knew why it was so complicated
    (and nobody really knew):
    https://cloudfoundry.slack.com/archives/C032824SM/p1594316115396400

    Co-authored-by: Merric De Launey <mdelauney@pivotal.io>
    Co-authored-by: Reid Mitchell <rmitchell@pivotal.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant