fix kafka unmarshaller args typing and defaults#240
Merged
xSAVIKx merged 2 commits intocloudevents:mainfrom Oct 30, 2024
Merged
fix kafka unmarshaller args typing and defaults#240xSAVIKx merged 2 commits intocloudevents:mainfrom
xSAVIKx merged 2 commits intocloudevents:mainfrom
Conversation
Signed-off-by: Christoph Hösler <christoph.hoesler@inovex.de>
hoesler
force-pushed
the
fix-kafka-unmarshaller-typing
branch
from
0ce70aa to
80fcc1d
Compare
for more information, see https://pre-commit.ci
xSAVIKx
approved these changes
Oct 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
This PR fixes wrong typings and defaults of unmarshaller args in the from_* kafka conversion functions
One line description for the changelog
fixed typing and defaults of unmarshaller arguments in kafka conversion functions