Enhances detection of textual content-types#444
Merged
pierDipi merged 1 commit intocloudevents:masterfrom Jan 31, 2022
Merged
Conversation
JemDay
changed the title
pierDipi
reviewed
Jan 28, 2022
formats/protobuf/src/main/java/io/cloudevents/protobuf/ProtoSupport.java
Show resolved
Hide resolved
formats/protobuf/src/test/java/io/cloudevents/protobuf/ProtoSupportTest.java
Show resolved
Hide resolved
formats/protobuf/src/main/java/io/cloudevents/protobuf/ProtoSupport.java
Outdated
Show resolved
Hide resolved
Member
protobuf field usage. Moved content-type introspection in a seprate support class. Added unit tests to ensure introspection is correct. Addressed review comments Signed-off-by: Day, Jeremy(jday) <jday@paypal.com>
Contributor
Author
|
@pierDipi - I believe I've addressed all of the comments. |
pierDipi
approved these changes
Jan 31, 2022
Member
pierDipi
left a comment
pierDipi
left a comment
There was a problem hiding this comment.
LGTM, this seems a breaking change so it needs a major version bump.
Member
|
Thanks for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensures correct protobuf field usage for text based content.
Moved content-type introspection in a seprate support class.
Added unit tests to ensure introspection is correct.
Fixes #443