fix: upgrade caldav for icalendar 7.x compatibility#397
Merged
Conversation
caldav 1.3.6 accesses `icalendar.cal.component_factory` as a dict, but icalendar 7.x refactored it into a module, causing: TypeError: 'module' object is not subscriptable Upgrade to caldav >=2.2.6 which supports icalendar >6.0.0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
caldavdependency from==1.3.6to>=2.2.6to fix incompatibility withicalendar>=7.0.0caldav1.3.6 accessesicalendar.cal.component_factoryas a dict, but icalendar 7.x refactored it into a module, causingTypeError: 'module' object is not subscriptablein all calendar operationsTest plan
caldav2.x API is backwards compatible —DAVClientandDAVResponseimports and constructor unchanged innc_py_api/calendar_api.py