-
Notifications
You must be signed in to change notification settings - Fork 437
feat(shared): Intelligent retries for existing clerk-js script #6860
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
9cae993
Intelligent retries for existing clerk-js script
brkalow 7d0b4fe
remove comments
brkalow 6b3efd1
tweak heuristic
brkalow cc1c00c
Merge branch 'main' into brk.feat/clerk-js-retry
brkalow 56a3aef
add tests for script load retries
brkalow 1540c2d
fix typo
brkalow a33cc02
fix more typos
brkalow ed9dd9f
adds changeset
brkalow File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| '@clerk/shared': minor | ||
| --- | ||
|
|
||
| Improve error handling and retry logic when loading `@clerk/clerk-js`. |
35 changes: 35 additions & 0 deletions
35
integration/templates/next-app-router/src/app/clerk-status/page.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| 'use client'; | ||
| import { ClerkLoaded, ClerkLoading, ClerkFailed, ClerkDegraded, useClerk } from '@clerk/nextjs'; | ||
|
|
||
| export default function ClerkStatusPage() { | ||
| const { loaded, status } = useClerk(); | ||
|
|
||
| return ( | ||
| <> | ||
| <p>Status: {status}</p> | ||
| <p>{status === 'loading' ? 'Clerk is loading' : null}</p> | ||
| <p>{status === 'error' ? 'Clerk is out' : null}</p> | ||
| <p>{status === 'degraded' ? 'Clerk is degraded' : null}</p> | ||
| <p>{status === 'ready' ? 'Clerk is ready' : null}</p> | ||
| <p>{status === 'ready' || status === 'degraded' ? 'Clerk is ready or degraded (loaded)' : null}</p> | ||
| <p>{loaded ? 'Clerk is loaded' : null}</p> | ||
| <p>{!loaded ? 'Clerk is NOT loaded' : null}</p> | ||
|
|
||
| <ClerkDegraded> | ||
| <p>(comp) Clerk is degraded</p> | ||
| </ClerkDegraded> | ||
|
|
||
| <ClerkLoaded> | ||
| <p>(comp) Clerk is loaded,(ready or degraded)</p> | ||
| </ClerkLoaded> | ||
|
|
||
| <ClerkFailed> | ||
| <p>(comp) Something went wrong with Clerk, refresh your page.</p> | ||
| </ClerkFailed> | ||
|
|
||
| <ClerkLoading> | ||
| <p>(comp) Waiting for clerk to fail, ready or degraded.</p> | ||
| </ClerkLoading> | ||
| </> | ||
| ); | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.