Skip to content

chore(clerk-js,localizations): Update TaskChooseOrganization copies for create organization screen #6584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LauraBeatris merged 5 commits into from
Aug 20, 2025
Merged

chore(clerk-js,localizations): Update TaskChooseOrganization copies for create organization screen #6584

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c4ac648
Update TaskChooseOrganization copies for create organization screen
iagodahlem Aug 20, 2025
cbec725
Add changeset
iagodahlem Aug 20, 2025
f85a558
Update specs
iagodahlem Aug 20, 2025
3623bbc
Generate new keys for all locales
iagodahlem Aug 20, 2025
db9f39d
Add changeset
iagodahlem Aug 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .changeset/curvy-shoes-create.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
---
'@clerk/localizations': patch
'@clerk/clerk-js': patch
'@clerk/testing': patch
'@clerk/types': patch
---

Update copies for create organization screen on session tasks
8 changes: 4 additions & 4 deletions .../src/ui/components/SessionTasks/tasks/TaskChooseOrganization/CreateOrganizationScreen.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,13 +28,13 @@ export const CreateOrganizationScreen = (props: CreateOrganizationScreenProps) =

const nameField = useFormControl('name', '', {
type: 'text',
label: localizationKeys('formFieldLabel__organizationName'),
placeholder: localizationKeys('formFieldInputPlaceholder__organizationName'),
label: localizationKeys('taskChooseOrganization.createOrganization.formFieldLabel__name'),
placeholder: localizationKeys('taskChooseOrganization.createOrganization.formFieldInputPlaceholder__name'),
});
const slugField = useFormControl('slug', '', {
type: 'text',
label: localizationKeys('formFieldLabel__organizationSlug'),
placeholder: localizationKeys('formFieldInputPlaceholder__organizationSlug'),
label: localizationKeys('taskChooseOrganization.createOrganization.formFieldLabel__slug'),
placeholder: localizationKeys('taskChooseOrganization.createOrganization.formFieldInputPlaceholder__slug'),
});
Comment on lines +31 to 38
Copy link
Contributor

@coderabbitai coderabbitai bot Aug 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Verification agent

🧩 Analysis chain

LGTM: localization keys correctly migrated to the new taskChooseOrganization path.

  • New label/placeholder keys align with the updated localization surface.
  • No logic changes; input validation and submission remain intact.

Run this quick check to ensure:

  • en-US has the new keys,
  • types include them,
  • no lingering references to the old keys in SessionTasks.

If you want, I can add a lightweight test that renders this screen with a mock localization to assert label/placeholder usage.

🏁 Script executed:

#!/bin/bash
set -euo pipefail

echo "Check en-US definitions for new keys:"
rg -nP "taskChooseOrganization\.createOrganization\.(formField(Label|InputPlaceholder)__(name|slug))\s*:" packages/localizations/src/en-US.ts -C2 || true

echo
echo "Check type surface includes the new keys:"
rg -nP "taskChooseOrganization.*createOrganization.*formFieldLabel__name" packages/types/src -n -C2 || true

echo
echo "Find any remaining references to old org name/slug keys in SessionTasks:"
rg -nP "formField(Label|InputPlaceholder)__organization(Name|Slug)" packages/clerk-js/src/ui/components/SessionTasks -n -C2 || true

Length of output: 765

Missing localization key definitions in en-US.ts and types

The new keys referenced in CreateOrganizationScreen.tsx aren’t defined in the localization files or the type surface, so they’ll break at runtime and in typing:

• packages/localizations/src/en-US.ts is missing:

  • taskChooseOrganization.createOrganization.formFieldLabel__name
  • taskChooseOrganization.createOrganization.formFieldInputPlaceholder__name
  • taskChooseOrganization.createOrganization.formFieldLabel__slug
  • taskChooseOrganization.createOrganization.formFieldInputPlaceholder__slug

• packages/types/src (your localization key union) needs to include those same four keys.

Suggested additions:

— packages/localizations/src/en-US.ts

export default {
  // …
  'taskChooseOrganization.createOrganization.formFieldLabel__name': 'Organization Name',
  'taskChooseOrganization.createOrganization.formFieldInputPlaceholder__name': 'Enter organization name',
  'taskChooseOrganization.createOrganization.formFieldLabel__slug': 'Organization Slug',
  'taskChooseOrganization.createOrganization.formFieldInputPlaceholder__slug': 'Enter organization slug',
  // …
}

— packages/types/src/index.ts (or wherever LocalizationKeys is defined)

export type LocalizationKeys =
  // …
  | 'taskChooseOrganization.createOrganization.formFieldLabel__name'
  | 'taskChooseOrganization.createOrganization.formFieldInputPlaceholder__name'
  | 'taskChooseOrganization.createOrganization.formFieldLabel__slug'
  | 'taskChooseOrganization.createOrganization.formFieldInputPlaceholder__slug'
  // …

Once those are in place, the labels and placeholders will resolve correctly.

🤖 Prompt for AI Agents 
In
packages/clerk-js/src/ui/components/SessionTasks/tasks/TaskChooseOrganization/CreateOrganizationScreen.tsx
around lines 31-38, the localization keys referenced for the name and slug
labels/placeholders are missing from the English localization and the
LocalizationKeys type union; add the following four keys to
packages/localizations/src/en-US.ts with appropriate English strings:
taskChooseOrganization.createOrganization.formFieldLabel__name,
taskChooseOrganization.createOrganization.formFieldInputPlaceholder__name,
taskChooseOrganization.createOrganization.formFieldLabel__slug,
taskChooseOrganization.createOrganization.formFieldInputPlaceholder__slug; then
update the localization keys union in packages/types/src (where LocalizationKeys
is defined) to include the exact same four string literal types so TypeScript
recognizes them; finally run the type check/build to ensure the keys resolve
correctly.


const onSubmit = async (e: React.FormEvent) => {
Expand Down
12 changes: 6 additions & 6 deletions ...nents/SessionTasks/tasks/TaskChooseOrganization/__tests__/TaskChooseOrganization.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,8 @@ describe('TaskChooseOrganization', () => {
const { queryByText, queryByRole } = render(<TaskChooseOrganization />, { wrapper });

await waitFor(() => {
expect(queryByText('Setup your account')).not.toBeInTheDocument();
expect(queryByText('Tell us a bit about your organization')).not.toBeInTheDocument();
expect(queryByText('Setup your organization')).not.toBeInTheDocument();
expect(queryByText('Enter your organization details to continue')).not.toBeInTheDocument();
expect(queryByRole('button', { name: /sign out/i })).not.toBeInTheDocument();
});
});
Expand All @@ -42,8 +42,8 @@ describe('TaskChooseOrganization', () => {
const { getByText, getByRole } = render(<TaskChooseOrganization />, { wrapper });

await waitFor(() => {
expect(getByText('Setup your account')).toBeInTheDocument();
expect(getByText('Tell us a bit about your organization')).toBeInTheDocument();
expect(getByText('Setup your organization')).toBeInTheDocument();
expect(getByText('Enter your organization details to continue')).toBeInTheDocument();
expect(getByRole('link', { name: /sign out/i })).toBeInTheDocument();
});
});
Expand All @@ -63,7 +63,7 @@ describe('TaskChooseOrganization', () => {

await waitFor(() => {
expect(getByRole('textbox', { name: /name/i })).toBeInTheDocument();
expect(getByText('Create new organization')).toBeInTheDocument();
expect(getByText('Continue')).toBeInTheDocument();
});
});

Expand Down Expand Up @@ -151,7 +151,7 @@ describe('TaskChooseOrganization', () => {

await waitFor(() => {
expect(getByRole('textbox', { name: /name/i })).toBeInTheDocument();
expect(getByRole('button', { name: /create new organization/i })).toBeInTheDocument();
expect(getByRole('button', { name: /continue/i })).toBeInTheDocument();
expect(getByRole('button', { name: /cancel/i })).toBeInTheDocument();
expect(queryByText('Existing Org')).not.toBeInTheDocument();
});
Expand Down
4 changes: 4 additions & 0 deletions packages/localizations/src/ar-SA.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -813,6 +813,10 @@ export const arSA: LocalizationResource = {
createOrganization: {
formButtonReset: undefined,
formButtonSubmit: undefined,
formFieldInputPlaceholder__name: undefined,
formFieldInputPlaceholder__slug: undefined,
formFieldLabel__name: undefined,
formFieldLabel__slug: undefined,
subtitle: undefined,
title: undefined,
},
Expand Down
4 changes: 4 additions & 0 deletions packages/localizations/src/be-BY.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -820,6 +820,10 @@ export const beBY: LocalizationResource = {
createOrganization: {
formButtonReset: undefined,
formButtonSubmit: undefined,
formFieldInputPlaceholder__name: undefined,
formFieldInputPlaceholder__slug: undefined,
formFieldLabel__name: undefined,
formFieldLabel__slug: undefined,
subtitle: undefined,
title: undefined,
},
Expand Down
4 changes: 4 additions & 0 deletions packages/localizations/src/bg-BG.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -816,6 +816,10 @@ export const bgBG: LocalizationResource = {
createOrganization: {
formButtonReset: undefined,
formButtonSubmit: undefined,
formFieldInputPlaceholder__name: undefined,
formFieldInputPlaceholder__slug: undefined,
formFieldLabel__name: undefined,
formFieldLabel__slug: undefined,
subtitle: undefined,
title: undefined,
},
Expand Down
4 changes: 4 additions & 0 deletions packages/localizations/src/bn-IN.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -820,6 +820,10 @@ export const bnIN: LocalizationResource = {
createOrganization: {
formButtonReset: undefined,
formButtonSubmit: undefined,
formFieldInputPlaceholder__name: undefined,
formFieldInputPlaceholder__slug: undefined,
formFieldLabel__name: undefined,
formFieldLabel__slug: undefined,
subtitle: undefined,
title: undefined,
},
Expand Down
4 changes: 4 additions & 0 deletions packages/localizations/src/ca-ES.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -815,6 +815,10 @@ export const caES: LocalizationResource = {
createOrganization: {
formButtonReset: undefined,
formButtonSubmit: undefined,
formFieldInputPlaceholder__name: undefined,
formFieldInputPlaceholder__slug: undefined,
formFieldLabel__name: undefined,
formFieldLabel__slug: undefined,
subtitle: undefined,
title: undefined,
},
Expand Down
4 changes: 4 additions & 0 deletions packages/localizations/src/cs-CZ.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -826,6 +826,10 @@ export const csCZ: LocalizationResource = {
createOrganization: {
formButtonReset: undefined,
formButtonSubmit: undefined,
formFieldInputPlaceholder__name: undefined,
formFieldInputPlaceholder__slug: undefined,
formFieldLabel__name: undefined,
formFieldLabel__slug: undefined,
subtitle: undefined,
title: undefined,
},
Expand Down
4 changes: 4 additions & 0 deletions packages/localizations/src/da-DK.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -813,6 +813,10 @@ export const daDK: LocalizationResource = {
createOrganization: {
formButtonReset: undefined,
formButtonSubmit: undefined,
formFieldInputPlaceholder__name: undefined,
formFieldInputPlaceholder__slug: undefined,
formFieldLabel__name: undefined,
formFieldLabel__slug: undefined,
Comment on lines +816 to +819
Copy link
Contributor

@coderabbitai coderabbitai bot Aug 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Verification agent

🧩 Analysis chain

Provide Danish labels/placeholders for create-organization fields in the task flow.

These are the keys directly tied to the PR objective. Recommend aligning with existing translations used elsewhere (e.g., organizationName/organizationSlug) for consistency.

Apply this diff:

-      formFieldInputPlaceholder__name: undefined,
-      formFieldInputPlaceholder__slug: undefined,
-      formFieldLabel__name: undefined,
-      formFieldLabel__slug: undefined,
+      formFieldInputPlaceholder__name: 'Indtast organisationens navn',
+      formFieldInputPlaceholder__slug: 'Indtast slug URL',
+      formFieldLabel__name: 'Navn',
+      formFieldLabel__slug: 'Slug URL',

To verify the new keys exist in the base locale and are consumed consistently, run:

🏁 Script executed:

#!/bin/bash
set -euo pipefail

# Locate files
EN_FILE="$(fd -t f 'en-US.ts' | head -n1)"
DK_FILE="$(fd -t f 'da-DK.ts' | head -n1)"

if [[ -z "${EN_FILE:-}" || -z "${DK_FILE:-}" ]]; then
  echo "Could not locate en-US.ts or da-DK.ts" >&2
  exit 1
fi

echo "en-US: $EN_FILE"
echo "da-DK: $DK_FILE"
echo

# Keys to verify across locales
keys=(
  'cancelFreeTrial:'
  'cancelFreeTrialDescription:'
  'cancelFreeTrialTitle:'
  'keepFreeTrial:'
  'firstPaymentAmount:'
  'firstPaymentOn:'
  'trialEndsOn:'
  'trialStartedOn:'
  'formFieldInputPlaceholder__name:'
  'formFieldInputPlaceholder__slug:'
  'formFieldLabel__name:'
  'formFieldLabel__slug:'
)

missing=false
for k in "${keys[@]}"; do
  echo "=== Key: $k"
  rg -nP "$k" "$EN_FILE" -C1 || { echo "Missing in en-US: $k"; missing=true; }
  rg -nP "$k" "$DK_FILE" -n || { echo "Missing in da-DK: $k"; missing=true; }
  echo
done

$missing && { echo "One or more keys missing. Please reconcile."; exit 1; } || echo "All keys present in en-US and da-DK."

Length of output: 6208


---

🏁 Script executed:

```shell
#!/bin/bash
set -euo pipefail

EN_FILE="packages/localizations/src/en-US.ts"
DK_FILE="packages/localizations/src/da-DK.ts"

echo "=== organizationName in en-US.ts ==="
rg -nP "organizationName:" "$EN_FILE" -C1 || echo "not found"
echo

echo "=== organizationName in da-DK.ts ==="
rg -nP "organizationName:" "$DK_FILE" -C1 || echo "not found"
echo

echo "=== organizationSlug in en-US.ts ==="
rg -nP "organizationSlug:" "$EN_FILE" -C1 || echo "not found"
echo

echo "=== organizationSlug in da-DK.ts ==="
rg -nP "organizationSlug:" "$DK_FILE" -C1 || echo "not found"
echo

echo "=== Context around other 'Slug' translations in da-DK.ts ==="
rg -nP "Slug" "$DK_FILE" -C2 | head -n20
```

Length of output: 3321

---



</details>

**Add Danish translations for create-organization placeholders and labels**

Please update packages/localizations/src/da-DK.ts around lines 816–819 to mirror the existing organizationName/organizationSlug translations:

```diff
@@ packages/localizations/src/da-DK.ts
-      formFieldInputPlaceholder__name: undefined,
+      formFieldInputPlaceholder__name: 'Indtast organisationens navn',
-      formFieldInputPlaceholder__slug: undefined,
+      formFieldInputPlaceholder__slug: 'Indtast slug URL',
-      formFieldLabel__name: undefined,
+      formFieldLabel__name: 'Organisationens navn',
-      formFieldLabel__slug: undefined,
+      formFieldLabel__slug: 'Slug URL',
```

• These keys already exist in en-US.ts and da-DK.ts but are currently undefined.  
• Aligning with the domain-verification translations ensures consistency.  
• Let me know if you’d like any help verifying or adjusting phrasing.

<!-- suggestion_start -->

<details>
<summary>📝 Committable suggestion</summary>

> ‼️ **IMPORTANT**
> Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

```suggestion
      formFieldInputPlaceholder__name: 'Indtast organisationens navn',
      formFieldInputPlaceholder__slug: 'Indtast slug URL',
      formFieldLabel__name: 'Organisationens navn',
      formFieldLabel__slug: 'Slug URL',
```

</details>

<!-- suggestion_end -->

<details>
<summary>🤖 Prompt for AI Agents</summary>

```
In packages/localizations/src/da-DK.ts around lines 816 to 819, four keys
(formFieldInputPlaceholder__name, formFieldInputPlaceholder__slug,
formFieldLabel__name, formFieldLabel__slug) are set to undefined; replace the
undefined values with the Danish strings matching the existing
organizationName/organizationSlug translations (use the same phrasing used
elsewhere in this file for organizationName and organizationSlug), i.e. set the
placeholder keys to the Danish placeholder text and the label keys to the Danish
label text so they mirror en-US entries and maintain consistency with
domain-verification translations.
```

</details>

<!-- fingerprinting:phantom:poseidon:chinchilla -->

<!-- This is an auto-generated comment by CodeRabbit -->

subtitle: undefined,
title: undefined,
},
Expand Down
4 changes: 4 additions & 0 deletions packages/localizations/src/de-DE.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -826,6 +826,10 @@ export const deDE: LocalizationResource = {
createOrganization: {
formButtonReset: undefined,
formButtonSubmit: undefined,
formFieldInputPlaceholder__name: undefined,
formFieldInputPlaceholder__slug: undefined,
formFieldLabel__name: undefined,
formFieldLabel__slug: undefined,
Comment on lines +829 to +832
Copy link
Contributor

@coderabbitai coderabbitai bot Aug 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Verification agent

🧩 Analysis chain

Do not set new create-organization field keys to undefined (breaks fallback, renders blanks).

Explicit undefined will override the en-US base during deep-merge, yielding empty labels/placeholders in the UI. Either provide German translations or remove these entries so the runtime falls back to en-US.

Preferred quick fix: remove to allow fallback

-      formFieldInputPlaceholder__name: undefined,
-      formFieldInputPlaceholder__slug: undefined,
-      formFieldLabel__name: undefined,
-      formFieldLabel__slug: undefined,

Alternative: add translations now

-      formFieldInputPlaceholder__name: undefined,
-      formFieldInputPlaceholder__slug: undefined,
-      formFieldLabel__name: undefined,
-      formFieldLabel__slug: undefined,
+      formFieldInputPlaceholder__name: 'Name der Organisation eingeben',
+      formFieldInputPlaceholder__slug: 'my-org',
+      formFieldLabel__name: 'Name',
+      formFieldLabel__slug: 'Slug',

🏁 Script executed:

#!/bin/bash
set -euo pipefail

# 1) Confirm en-US has the new keys for fallback
fd -a en-US.ts | while read -r f; do
  echo "Checking keys in $f"
  rg -n -C2 "taskChooseOrganization|formFieldLabel__name|formFieldInputPlaceholder__name|formFieldLabel__slug|formFieldInputPlaceholder__slug" "$f" || true
done

# 2) Inspect localization merge to verify that explicit `undefined` overrides base strings
rg -n -C3 "parseLocalizationResource|fastDeepMerge" packages -g '!**/dist/**' -g '!**/build/**' || true

Length of output: 16516

Remove undefined create-organization keys in de-DE localization

Explicit undefined entries in the German resource will override the en-US defaults (via fastDeepMergeAndReplace), resulting in blank labels/placeholders in the UI. Either supply valid German strings now or delete these lines so the runtime can fall back to en-US.

• File: packages/localizations/src/de-DE.ts
Lines: 829–832

Preferred quick fix – allow fallback:

-      formFieldInputPlaceholder__name: undefined,
-      formFieldInputPlaceholder__slug: undefined,
-      formFieldLabel__name: undefined,
-      formFieldLabel__slug: undefined,

Alternative – add German translations:

-      formFieldInputPlaceholder__name: undefined,
-      formFieldInputPlaceholder__slug: undefined,
-      formFieldLabel__name: undefined,
-      formFieldLabel__slug: undefined,
+      formFieldInputPlaceholder__name: 'Name der Organisation eingeben',
+      formFieldInputPlaceholder__slug: 'my-org',
+      formFieldLabel__name: 'Name',
+      formFieldLabel__slug: 'Slug',
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
formFieldInputPlaceholder__name: undefined,
formFieldInputPlaceholder__slug: undefined,
formFieldLabel__name: undefined,
formFieldLabel__slug: undefined,
🤖 Prompt for AI Agents 
In packages/localizations/src/de-DE.ts around lines 829 to 832, the four
create-organization keys are explicitly set to undefined which overrides en-US
defaults and causes blank UI labels; either remove these four entries
(formFieldInputPlaceholder__name, formFieldInputPlaceholder__slug,
formFieldLabel__name, formFieldLabel__slug) so the runtime falls back to en-US,
or replace each undefined with the appropriate German translation strings (e.g.,
placeholders/labels in German) ensuring no undefined values remain.

subtitle: undefined,
title: undefined,
},
Expand Down
4 changes: 4 additions & 0 deletions packages/localizations/src/el-GR.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -817,6 +817,10 @@ export const elGR: LocalizationResource = {
createOrganization: {
formButtonReset: undefined,
formButtonSubmit: undefined,
formFieldInputPlaceholder__name: undefined,
formFieldInputPlaceholder__slug: undefined,
formFieldLabel__name: undefined,
formFieldLabel__slug: undefined,
subtitle: undefined,
title: undefined,
},
Expand Down
4 changes: 4 additions & 0 deletions packages/localizations/src/en-GB.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -817,6 +817,10 @@ export const enGB: LocalizationResource = {
createOrganization: {
formButtonReset: undefined,
formButtonSubmit: undefined,
formFieldInputPlaceholder__name: undefined,
formFieldInputPlaceholder__slug: undefined,
formFieldLabel__name: undefined,
formFieldLabel__slug: undefined,
subtitle: undefined,
title: undefined,
},
Expand Down
10 changes: 7 additions & 3 deletions packages/localizations/src/en-US.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -812,9 +812,13 @@ export const enUS: LocalizationResource = {
},
createOrganization: {
formButtonReset: 'Cancel',
formButtonSubmit: 'Create new organization',
subtitle: 'Tell us a bit about your organization',
title: 'Setup your account',
formButtonSubmit: 'Continue',
formFieldInputPlaceholder__name: 'My Organization',
formFieldInputPlaceholder__slug: 'my-organization',
formFieldLabel__name: 'Name',
formFieldLabel__slug: 'Slug',
subtitle: 'Enter your organization details to continue',
title: 'Setup your organization',
},
signOut: {
actionLink: 'Sign out',
Expand Down
4 changes: 4 additions & 0 deletions packages/localizations/src/es-CR.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -822,6 +822,10 @@ export const esCR: LocalizationResource = {
createOrganization: {
formButtonReset: undefined,
formButtonSubmit: undefined,
formFieldInputPlaceholder__name: undefined,
formFieldInputPlaceholder__slug: undefined,
formFieldLabel__name: undefined,
formFieldLabel__slug: undefined,
Comment on lines +825 to +828
Copy link
Contributor

@coderabbitai coderabbitai bot Aug 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Verification agent

🧩 Analysis chain

Populate create-organization labels/placeholders for the session task (suggested es-CR)

Setting these avoids en-US fallback in the new Create Organization screen.

Apply:

-      formFieldInputPlaceholder__name: undefined,
-      formFieldInputPlaceholder__slug: undefined,
-      formFieldLabel__name: undefined,
-      formFieldLabel__slug: undefined,
+      formFieldInputPlaceholder__name: 'Mi organización',
+      formFieldInputPlaceholder__slug: 'mi-organizacion',
+      formFieldLabel__name: 'Nombre',
+      formFieldLabel__slug: 'Apodo',

To verify usage aligns with the new path:

🏁 Script executed:

#!/bin/bash
set -euo pipefail

echo "Check UI references the new taskChooseOrganization.createOrganization keys"
rg -nP "taskChooseOrganization\.createOrganization\.(formField(Label|InputPlaceholder)__(name|slug))" packages/clerk-js -C2

Length of output: 2075

Populate es-CR translations for Create Organization form fields

To prevent falling back to en-US in the new Create Organization screen, add the Spanish (Costa Rica) labels and placeholders for the taskChooseOrganization.createOrganization keys. Verified that CreateOrganizationScreen.tsx references all four keys.

File: packages/localizations/src/es-CR.ts (around lines 825–828)

-      formFieldInputPlaceholder__name: undefined,
-      formFieldInputPlaceholder__slug: undefined,
-      formFieldLabel__name: undefined,
-      formFieldLabel__slug: undefined,
+      formFieldInputPlaceholder__name: 'Mi organización',
+      formFieldInputPlaceholder__slug: 'mi-organizacion',
+      formFieldLabel__name: 'Nombre',
+      formFieldLabel__slug: 'Apodo',
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
formFieldInputPlaceholder__name: undefined,
formFieldInputPlaceholder__slug: undefined,
formFieldLabel__name: undefined,
formFieldLabel__slug: undefined,
formFieldInputPlaceholder__name: 'Mi organización',
formFieldInputPlaceholder__slug: 'mi-organizacion',
formFieldLabel__name: 'Nombre',
formFieldLabel__slug: 'Apodo',
🤖 Prompt for AI Agents 
In packages/localizations/src/es-CR.ts around lines 825–828, the four keys for
taskChooseOrganization.createOrganization are left undefined causing fallback to
en-US; populate them with Spanish (Costa Rica) strings: set formFieldLabel__name
to "Nombre de la organización", formFieldInputPlaceholder__name to "Ingrese el
nombre de la organización", formFieldLabel__slug to "Slug de la organización",
and formFieldInputPlaceholder__slug to "Ingrese el slug de la organización" so
the Create Organization screen uses es-CR translations.

subtitle: undefined,
title: undefined,
},
Expand Down
4 changes: 4 additions & 0 deletions packages/localizations/src/es-ES.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -816,6 +816,10 @@ export const esES: LocalizationResource = {
createOrganization: {
formButtonReset: undefined,
formButtonSubmit: undefined,
formFieldInputPlaceholder__name: undefined,
formFieldInputPlaceholder__slug: undefined,
formFieldLabel__name: undefined,
formFieldLabel__slug: undefined,
Comment on lines +819 to +822
Copy link
Contributor

@coderabbitai coderabbitai bot Aug 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Verification agent

🧩 Analysis chain

LGTM on key naming/location; values need completion

The new keys are correctly scoped under taskChooseOrganization.createOrganization and match the types introduced in packages/types/src/localization.ts. Only the values are missing.

Run the following to verify type coverage and en-US baseline values for these keys:

🏁 Script executed:

#!/bin/bash
set -euo pipefail

echo "Check that types include the new keys:"
rg -n "formField(InputPlaceholder|Label)__name|formField(InputPlaceholder|Label)__slug" packages/types/src/localization.ts -C3 --type=ts

echo
echo "Show en-US values for the same keys (should be defined):"
rg -n "formField(InputPlaceholder|Label)__name|formField(InputPlaceholder|Label)__slug" packages/localizations/src/en-US.ts -C3 --type=ts

echo
echo "Scan all locales for missing values on the new keys (undefined):"
rg -nP --type=ts "taskChooseOrganization[\s\S]*createOrganization[\s\S]*formField(InputPlaceholder|Label)__(name|slug)\s*:\s*undefined" packages/localizations/src | sed 's/^/undefined: /'

echo
echo "Optional: list locales that already translated them (non-undefined):"
rg -nP --type=ts "taskChooseOrganization[\s\S]*createOrganization[\s\S]*formField(InputPlaceholder|Label)__(name|slug)\s*:\s*'[^']+'" packages/localizations/src | sed 's/^/translated: /'

Length of output: 1731

Complete missing translations for new localization keys

The new keys are correctly defined in the types and the en-US locale provides baseline values. Please supply translations for these keys in all non-en locale files—currently they’re left as undefined in es-ES:

• packages/localizations/src/es-ES.ts (lines 819–822):

  • formFieldInputPlaceholder__name
  • formFieldInputPlaceholder__slug
  • formFieldLabel__name
  • formFieldLabel__slug

Ensure no locale leaves these values undefined.

🤖 Prompt for AI Agents 
In packages/localizations/src/es-ES.ts around lines 819–822, four localization
keys are left undefined; replace them with Spanish translations mirroring the
en-US intent: set formFieldInputPlaceholder__name to "Introduce el nombre" (or
simply "Nombre" if placeholder is short), formFieldInputPlaceholder__slug to
"Introduce el slug" (or "Slug"), formFieldLabel__name to "Nombre" and
formFieldLabel__slug to "Slug"; ensure none remain undefined and follow the same
quoting/formatting style as the surrounding entries.

subtitle: undefined,
title: undefined,
},
Expand Down
4 changes: 4 additions & 0 deletions packages/localizations/src/es-MX.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -823,6 +823,10 @@ export const esMX: LocalizationResource = {
createOrganization: {
formButtonReset: undefined,
formButtonSubmit: undefined,
formFieldInputPlaceholder__name: undefined,
formFieldInputPlaceholder__slug: undefined,
formFieldLabel__name: undefined,
formFieldLabel__slug: undefined,
subtitle: undefined,
title: undefined,
},
Expand Down
4 changes: 4 additions & 0 deletions packages/localizations/src/es-UY.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -822,6 +822,10 @@ export const esUY: LocalizationResource = {
createOrganization: {
formButtonReset: undefined,
formButtonSubmit: undefined,
formFieldInputPlaceholder__name: undefined,
formFieldInputPlaceholder__slug: undefined,
formFieldLabel__name: undefined,
formFieldLabel__slug: undefined,
subtitle: undefined,
title: undefined,
},
Expand Down
4 changes: 4 additions & 0 deletions packages/localizations/src/fa-IR.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -826,6 +826,10 @@ export const faIR: LocalizationResource = {
createOrganization: {
formButtonReset: 'گذشتن',
formButtonSubmit: 'ایجاد سازمان',
formFieldInputPlaceholder__name: undefined,
formFieldInputPlaceholder__slug: undefined,
formFieldLabel__name: undefined,
formFieldLabel__slug: undefined,
subtitle: 'سازمان جدیدی برای شروع کار ایجاد کنید',
title: 'ایجاد سازمان جدید',
},
Expand Down
4 changes: 4 additions & 0 deletions packages/localizations/src/fi-FI.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -816,6 +816,10 @@ export const fiFI: LocalizationResource = {
createOrganization: {
formButtonReset: undefined,
formButtonSubmit: undefined,
formFieldInputPlaceholder__name: undefined,
formFieldInputPlaceholder__slug: undefined,
formFieldLabel__name: undefined,
formFieldLabel__slug: undefined,
subtitle: undefined,
title: undefined,
},
Expand Down
4 changes: 4 additions & 0 deletions packages/localizations/src/fr-FR.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -825,6 +825,10 @@ export const frFR: LocalizationResource = {
createOrganization: {
formButtonReset: undefined,
formButtonSubmit: undefined,
formFieldInputPlaceholder__name: undefined,
formFieldInputPlaceholder__slug: undefined,
formFieldLabel__name: undefined,
formFieldLabel__slug: undefined,
subtitle: undefined,
title: undefined,
},
Expand Down
4 changes: 4 additions & 0 deletions packages/localizations/src/he-IL.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -807,6 +807,10 @@ export const heIL: LocalizationResource = {
createOrganization: {
formButtonReset: undefined,
formButtonSubmit: undefined,
formFieldInputPlaceholder__name: undefined,
formFieldInputPlaceholder__slug: undefined,
formFieldLabel__name: undefined,
formFieldLabel__slug: undefined,
subtitle: undefined,
title: undefined,
},
Expand Down
4 changes: 4 additions & 0 deletions packages/localizations/src/hi-IN.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -820,6 +820,10 @@ export const hiIN: LocalizationResource = {
createOrganization: {
formButtonReset: undefined,
formButtonSubmit: undefined,
formFieldInputPlaceholder__name: undefined,
formFieldInputPlaceholder__slug: undefined,
formFieldLabel__name: undefined,
formFieldLabel__slug: undefined,
subtitle: undefined,
title: undefined,
},
Expand Down
4 changes: 4 additions & 0 deletions packages/localizations/src/hr-HR.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -817,6 +817,10 @@ export const hrHR: LocalizationResource = {
createOrganization: {
formButtonReset: undefined,
formButtonSubmit: undefined,
formFieldInputPlaceholder__name: undefined,
formFieldInputPlaceholder__slug: undefined,
formFieldLabel__name: undefined,
formFieldLabel__slug: undefined,
subtitle: undefined,
title: undefined,
},
Expand Down
4 changes: 4 additions & 0 deletions packages/localizations/src/hu-HU.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -814,6 +814,10 @@ export const huHU: LocalizationResource = {
createOrganization: {
formButtonReset: undefined,
formButtonSubmit: undefined,
formFieldInputPlaceholder__name: undefined,
formFieldInputPlaceholder__slug: undefined,
formFieldLabel__name: undefined,
formFieldLabel__slug: undefined,
subtitle: undefined,
title: undefined,
},
Expand Down
4 changes: 4 additions & 0 deletions packages/localizations/src/id-ID.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -821,6 +821,10 @@ export const idID: LocalizationResource = {
createOrganization: {
formButtonReset: undefined,
formButtonSubmit: undefined,
formFieldInputPlaceholder__name: undefined,
formFieldInputPlaceholder__slug: undefined,
formFieldLabel__name: undefined,
formFieldLabel__slug: undefined,
subtitle: undefined,
title: undefined,
},
Expand Down
4 changes: 4 additions & 0 deletions packages/localizations/src/is-IS.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -817,6 +817,10 @@ export const isIS: LocalizationResource = {
createOrganization: {
formButtonReset: undefined,
formButtonSubmit: undefined,
formFieldInputPlaceholder__name: undefined,
formFieldInputPlaceholder__slug: undefined,
formFieldLabel__name: undefined,
formFieldLabel__slug: undefined,
subtitle: undefined,
title: undefined,
},
Expand Down
4 changes: 4 additions & 0 deletions packages/localizations/src/it-IT.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -823,6 +823,10 @@ export const itIT: LocalizationResource = {
createOrganization: {
formButtonReset: undefined,
formButtonSubmit: undefined,
formFieldInputPlaceholder__name: undefined,
formFieldInputPlaceholder__slug: undefined,
formFieldLabel__name: undefined,
formFieldLabel__slug: undefined,
subtitle: undefined,
title: undefined,
},
Expand Down
4 changes: 4 additions & 0 deletions packages/localizations/src/ja-JP.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -815,6 +815,10 @@ export const jaJP: LocalizationResource = {
createOrganization: {
formButtonReset: undefined,
formButtonSubmit: undefined,
formFieldInputPlaceholder__name: undefined,
formFieldInputPlaceholder__slug: undefined,
formFieldLabel__name: undefined,
formFieldLabel__slug: undefined,
subtitle: undefined,
title: undefined,
},
Expand Down
4 changes: 4 additions & 0 deletions packages/localizations/src/kk-KZ.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -807,6 +807,10 @@ export const kkKZ: LocalizationResource = {
createOrganization: {
formButtonReset: undefined,
formButtonSubmit: undefined,
formFieldInputPlaceholder__name: undefined,
formFieldInputPlaceholder__slug: undefined,
formFieldLabel__name: undefined,
formFieldLabel__slug: undefined,
Comment on lines +810 to +813
Copy link
Contributor

@coderabbitai coderabbitai bot Aug 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Verification agent

🧩 Analysis chain

Avoid undefined on new create-organization keys; fallback will be overridden and UI will be blank.

Provide Kazakh strings or remove these keys to inherit en-US.

Preferred quick fix: remove to allow fallback

-      formFieldInputPlaceholder__name: undefined,
-      formFieldInputPlaceholder__slug: undefined,
-      formFieldLabel__name: undefined,
-      formFieldLabel__slug: undefined,

Alternative: add Kazakh translations

-      formFieldInputPlaceholder__name: undefined,
-      formFieldInputPlaceholder__slug: undefined,
-      formFieldLabel__name: undefined,
-      formFieldLabel__slug: undefined,
+      formFieldInputPlaceholder__name: 'Ұйым атауын енгізіңіз',
+      formFieldInputPlaceholder__slug: 'my-org',
+      formFieldLabel__name: 'Атауы',
+      formFieldLabel__slug: 'Slug',

🏁 Script executed:

#!/bin/bash
set -euo pipefail

# 1) Confirm en-US has the keys present for fallback
fd -a en-US.ts | while read -r f; do
  rg -n -C2 "taskChooseOrganization|formFieldLabel__name|formFieldInputPlaceholder__name|formFieldLabel__slug|formFieldInputPlaceholder__slug" "$f" || true
done

# 2) Inspect merge behavior to ensure undefined overrides base (helps decide remove vs translate)
rg -n -C3 "parseLocalizationResource|fastDeepMerge" packages -g '!**/dist/**' -g '!**/build/**' || true

Length of output: 16363

Remove undefined overrides in kk-KZ localization

The four undefined entries in packages/localizations/src/kk-KZ.ts (lines 810–813) will override the en-US defaults and result in blank placeholders/labels. Either remove them to inherit the English fallback or supply proper Kazakh strings.

• File: packages/localizations/src/kk-KZ.ts (lines 810–813)
Preferred quick fix – remove keys to allow fallback:

-      formFieldInputPlaceholder__name: undefined,
-      formFieldInputPlaceholder__slug: undefined,
-      formFieldLabel__name: undefined,
-      formFieldLabel__slug: undefined,

Alternative – add Kazakh translations:

-      formFieldInputPlaceholder__name: undefined,
-      formFieldInputPlaceholder__slug: undefined,
-      formFieldLabel__name: undefined,
-      formFieldLabel__slug: undefined,
+      formFieldInputPlaceholder__name: 'Ұйым атауын енгізіңіз',
+      formFieldInputPlaceholder__slug: 'my-org',
+      formFieldLabel__name: 'Атауы',
+      formFieldLabel__slug: 'Slug',
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
formFieldInputPlaceholder__name: undefined,
formFieldInputPlaceholder__slug: undefined,
formFieldLabel__name: undefined,
formFieldLabel__slug: undefined,
🤖 Prompt for AI Agents 
In packages/localizations/src/kk-KZ.ts around lines 810 to 813, four entries
(formFieldInputPlaceholder__name, formFieldInputPlaceholder__slug,
formFieldLabel__name, formFieldLabel__slug) are set to undefined which overrides
the en-US defaults and yields blank UI; remove these four key lines to allow the
English fallback, or replace each undefined with the appropriate Kazakh string
if translations are available.

subtitle: undefined,
title: undefined,
},
Expand Down
4 changes: 4 additions & 0 deletions packages/localizations/src/ko-KR.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -809,6 +809,10 @@ export const koKR: LocalizationResource = {
createOrganization: {
formButtonReset: undefined,
formButtonSubmit: undefined,
formFieldInputPlaceholder__name: undefined,
formFieldInputPlaceholder__slug: undefined,
formFieldLabel__name: undefined,
formFieldLabel__slug: undefined,
subtitle: undefined,
title: undefined,
},
Expand Down
4 changes: 4 additions & 0 deletions packages/localizations/src/mn-MN.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -815,6 +815,10 @@ export const mnMN: LocalizationResource = {
createOrganization: {
formButtonReset: undefined,
formButtonSubmit: undefined,
formFieldInputPlaceholder__name: undefined,
formFieldInputPlaceholder__slug: undefined,
formFieldLabel__name: undefined,
formFieldLabel__slug: undefined,
subtitle: undefined,
title: undefined,
},
Expand Down
Loading
Loading