Skip to content

fix(clerk-js): Ensure setActive does not emit token before onBeforeSetActive #5986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brkalow merged 4 commits into from
May 28, 2025
Merged

fix(clerk-js): Ensure setActive does not emit token before onBeforeSetActive #5986

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
54246ed
ensure setActive emits the previous token before onBeforeSetActive() …
brkalow May 22, 2025
d9831b0
adds changeset
brkalow May 22, 2025
3f2af89
Remove token update altogether
brkalow May 23, 2025
8f3db30
Merge branch 'main' into brk.fix/set-active-emit-previous-token
brkalow May 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/crazy-readers-flow.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@clerk/clerk-js': patch
---

Fix an issue where clerk-js was incorrectly emitting the new session's token during session switching. This impacts some applications that rely on Clerk's multi-session behavior.
2 changes: 1 addition & 1 deletion packages/clerk-js/src/core/__tests__/clerk.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,7 @@ describe('Clerk singleton', () => {
getToken: jest.fn(),
lastActiveToken: { getRawString: () => 'mocked-token' },
};
let eventBusSpy;
let eventBusSpy: jest.SpyInstance;

beforeEach(() => {
eventBusSpy = jest.spyOn(eventBus, 'emit');
Expand Down
4 changes: 0 additions & 4 deletions packages/clerk-js/src/core/clerk.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1094,10 +1094,6 @@ export class Clerk implements ClerkInterface {
return;
}

if (session?.lastActiveToken) {
eventBus.emit(events.TokenUpdate, { token: session.lastActiveToken });
}

/**
* Hint to each framework, that the user will be signed out when `{session: null}` is provided.
*/
Expand Down
Loading