Skip to content

chore(clerk-js,types): Add descriptor to user preview idetifier text #5878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexcarpenter merged 2 commits into from
May 7, 2025
Merged

chore(clerk-js,types): Add descriptor to user preview idetifier text #5878

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e095bf2
chore(clerk-js,types): Add descriptor to user preview idetifier text
alexcarpenter May 7, 2025
090165d
add changeset
alexcarpenter May 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/purple-ghosts-win.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
'@clerk/clerk-js': patch
'@clerk/types': patch
---

Add element descriptor to the text element rendered within UserPreview component.
1 change: 1 addition & 0 deletions packages/clerk-js/src/ui/customizables/elementDescriptors.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,6 +215,7 @@ export const APPEARANCE_KEYS = containsAllElementsConfigKeys([
'userPreviewAvatarIcon',
'userPreviewTextContainer',
'userPreviewMainIdentifier',
'userPreviewMainIdentifierText',
'userPreviewSecondaryIdentifier',

'organizationPreview',
Expand Down
3 changes: 2 additions & 1 deletion packages/clerk-js/src/ui/elements/UserPreview.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,14 +153,15 @@ export const UserPreview = (props: UserPreviewProps) => {
>
{previewTitle && (
<Text
elementDescriptor={descriptors.userPreviewMainIdentifierText}
elementId={descriptors.userPreviewMainIdentifierText.setId(elementId)}
as='span'
truncate
sx={{ fontWeight: 'inherit' }}
>
{previewTitle}
</Text>
)}

{badge}
</Text>

Expand Down
1 change: 1 addition & 0 deletions packages/types/src/appearance.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -347,6 +347,7 @@ export type ElementsConfig = {
userPreviewAvatarIcon: WithOptions<UserPreviewId>;
userPreviewTextContainer: WithOptions<UserPreviewId>;
userPreviewMainIdentifier: WithOptions<UserPreviewId>;
userPreviewMainIdentifierText: WithOptions<UserPreviewId>;
userPreviewSecondaryIdentifier: WithOptions<UserPreviewId>;

organizationPreview: WithOptions<OrganizationPreviewId>;
Expand Down