Skip to content

Conversation

@wobsoriano
Copy link
Member

Description

Fixes CI build release error. Follow up to #3975

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@changeset-bot
Copy link

changeset-bot bot commented Aug 19, 2024

🦋 Changeset detected

Latest commit: 32da7e5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@clerk/localizations Patch
@clerk/clerk-js Patch
@clerk/chrome-extension Patch
@clerk/clerk-expo Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@wobsoriano wobsoriano changed the title fix(types): Add missing key types fix(types): Add missing localization key types Aug 19, 2024
@wobsoriano wobsoriano marked this pull request as ready for review August 19, 2024 15:46
Copy link
Member

@anagstef anagstef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should remove these keys from the da-DK file. These are not used anywhere.

@wobsoriano wobsoriano changed the title fix(types): Add missing localization key types chore(localizations): Remove unused Danish localization translations Aug 19, 2024
Copy link
Member

@anagstef anagstef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 Thanks!

@wobsoriano wobsoriano merged commit ec6bfb5 into main Aug 19, 2024
@wobsoriano wobsoriano deleted the types-localization-fix branch August 19, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants