Skip to content

Conversation

@panteliselef
Copy link
Contributor

Description

Since clerk-js is being hotloaded it is unnecessary to keep the npm package as a dependency

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Since clerk-js is being hotloaded it is unnecessary to keep the npm package as a dependency
@changeset-bot
Copy link

changeset-bot bot commented Aug 15, 2024

🦋 Changeset detected

Latest commit: 2f01863

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@clerk/astro Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@panteliselef panteliselef self-assigned this Aug 15, 2024
Copy link
Member

@wobsoriano wobsoriano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 🚀

@panteliselef panteliselef enabled auto-merge (squash) August 15, 2024 17:52
@panteliselef panteliselef merged commit e75d2de into main Aug 15, 2024
@panteliselef panteliselef deleted the elef/eco-131-remove-dependency-clerkclerk-js-from-clerkastro branch August 15, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants