-
Notifications
You must be signed in to change notification settings - Fork 426
fix(clerk-expo): Export useLocalCredentials from a submodule
#3954
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(clerk-expo): Export useLocalCredentials from a submodule
#3954
Conversation
Turns out that tree shaking does not work as expected, and when importing any hook into an app that does not have `expo-local-authentication` installed the app will break due to the missing dependency.
🦋 Changeset detectedLatest commit: ccc03ea The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
!snapshot |
|
Hey @panteliselef - the snapshot version command generated the following package versions:
Tip: Use the snippet copy button below to quickly install the required packages. npm i @clerk/[email protected] --save-exact
npm i @clerk/[email protected] --save-exact
npm i @clerk/[email protected] --save-exact
npm i @clerk/[email protected] --save-exact
npm i @clerk/[email protected] --save-exact
npm i @clerk/[email protected] --save-exact
npm i @clerk/[email protected] --save-exact
npm i @clerk/[email protected] --save-exact
npm i @clerk/[email protected] --save-exact
npm i @clerk/[email protected] --save-exact
npm i @clerk/[email protected] --save-exact
npm i @clerk/[email protected] --save-exact
npm i @clerk/[email protected] --save-exact
npm i @clerk/[email protected] --save-exact
npm i @clerk/[email protected] --save-exact
npm i @clerk/[email protected] --save-exact
npm i @clerk/[email protected] --save-exact
npm i @clerk/[email protected] --save-exact |
.changeset/olive-snakes-judge.md
Outdated
| "@clerk/clerk-expo": minor | ||
| --- | ||
|
|
||
| **Breaking**: Export `useLocalCredentials` from a submodule. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❓ Is it ok to introduce a breaking change in a minor release?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@anagstef , the breaking change was already released in 3663 as a minor release. This was presumably by accident, due to unexpected expectations of how tree shaking would work with metro. So, technically no, its not ok but its already done; but it wasn't intended to be breaking either.
This fix is the "correction" for that. If this 'fixes' the break, then the feature itself is indeed nonbreaking, so this would be a patch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be clear: this PR would be a patch and the feature would be ( once corrected ) a minor since its not an intentional breaking change requiring a migration, and doesn't deprecate any surface of the api.
If you must install the additional dependency still, then it would be a major change, because that is intentional feature addition requiring a migration.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd have to agree that this is a breaking change, but it needs to be released as minor is order to fix a bug + introduces an API change.
|
thanks for looking into this and responding so quickly to issue #3950, @panteliselef |
|
@panteliselef Awesome work 🏅 |
Co-authored-by: Lennart <[email protected]>
…expo-will-require-expo-local
Co-authored-by: Lennart <[email protected]>
Description
Turns out that tree shaking does not work as expected, and when importing any hook into an app that does not have
expo-local-authenticationinstalled the app will break due to the missing dependency.Before
After
Updated Docs PR
Checklist
npm testruns as expected.npm run buildruns as expected.Type of change