fix(clerk-js,elements,types,ui): Account for null in supported_first_factors#3938
Merged
fix(clerk-js,elements,types,ui): Account for null in supported_first_factors#3938
null in supported_first_factors#3938Conversation
🦋 Changeset detectedLatest commit: 19af466 The changes in this PR will be included in the next version bump. This PR includes changesets to release 19 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
brkalow
approved these changes
Aug 13, 2024
LekoArts
approved these changes
Aug 13, 2024
null in supported_first_factors
panteliselef
approved these changes
Aug 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In certain situations (such as the
email_linksign in flow), the API returns"supported_first_factors": null. Currently, our types expect this value to always be an array, which results in a runtime TypeError when we attempt to use any method on the value expecting an array.Checklist
npm testruns as expected.npm run buildruns as expected.Type of change