feat(elements,ui): Add support for loading actions #3927
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 8223cd6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
brkalow
approved these changes
Aug 13, 2024
| </Card.Body> | ||
| <Card.Actions> | ||
| <Common.Loading> | ||
| <Common.Loading scope='submit'> |
Member
There was a problem hiding this comment.
will need this added to each submit action across both sign in and signup. Not just the start step.
dstaley
changed the title
alexcarpenter
approved these changes
Aug 15, 2024
Member
alexcarpenter
left a comment
alexcarpenter
left a comment
There was a problem hiding this comment.
👍🏼 I can follow up with the usage implementation in the UI components.
Member
brkalow
pushed a commit
that referenced
this pull request
Aug 22, 2024
Co-authored-by: Alex Carpenter <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for actions, which are smaller states within a step. This allows us to disambiguate loading states within a single step. This PR adds support for the
passkeyandsubmitactions withinstart, but also lays the foundation for future actions within other steps. This allows us to show the correct busy state on the related UI element.Checklist
npm testruns as expected.npm run buildruns as expected.Type of change